From 28954fea79e7b6c4d295015373c3f7c60ec10787 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 16 Mar 2026 05:39:57 -0600 Subject: [PATCH] chore(review): replace adversarial CodeRabbit with skill-validator refs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the cynical adversarial reviewer persona from .coderabbit.yaml and replace with per-path instructions that reference tools/skill-validator.md as the single source of truth — matching the approach already used in .augment/code_review_guidelines.yaml. Add skill-validator pointer to AGENTS.md so all AI tools can discover it. Co-Authored-By: Claude Opus 4.6 (1M context) --- .coderabbit.yaml | 42 ++++++++++++++++++++++++++---------------- AGENTS.md | 2 ++ 2 files changed, 28 insertions(+), 16 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 9b7f85774..e8ddc9aac 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -60,23 +60,33 @@ reviews: - "!**/validation-report-*.md" - "!CHANGELOG.md" path_instructions: - - path: "**/*" + - path: "src/**/skills/**" instructions: | - You are a cynical, jaded reviewer with zero patience for sloppy work. - This PR was submitted by a clueless weasel and you expect to find problems. - Be skeptical of everything. - Look for what's missing, not just what's wrong. - Use a precise, professional tone — no profanity or personal attacks. - - Review with extreme skepticism — assume problems exist. - Find at least 10 issues to fix or improve. - - Do NOT: - - Comment on formatting, linting, or style - - Give "looks good" passes - - Anchor on any specific ruleset — reason freely - - If you find zero issues, re-analyze — this is suspicious. + Skill file. Apply the full rule catalog defined in tools/skill-validator.md. + That document is the single source of truth for all skill validation rules + covering SKILL.md metadata, workflow.md constraints, step file structure, + path references, variable resolution, sequential execution, and skill + invocation syntax. + - path: "src/**/workflows/**" + instructions: | + Legacy workflow file (pre-skill conversion). Apply the full rule catalog + defined in tools/skill-validator.md — the same rules apply to workflows + that are being converted to skills. + - path: "src/**/tasks/**" + instructions: | + Task file. Apply the full rule catalog defined in tools/skill-validator.md. + - path: "src/**/*.agent.yaml" + instructions: | + Agent definition file. Check: + - Has metadata section with id, name, title, icon, and module + - Defines persona with role, identity, communication_style, and principles + - Menu triggers reference valid skill names that exist + - path: "docs/**/*.md" + instructions: | + Documentation file. Check internal markdown links point to existing files. + - path: "tools/**" + instructions: | + Build script/tooling. Check error handling and proper exit codes. chat: auto_reply: true # Response to mentions in comments, a la @coderabbit review issue_enrichment: diff --git a/AGENTS.md b/AGENTS.md index 1b68191e5..9f5af3b30 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -7,3 +7,5 @@ Open source framework for structured, agent-assisted software delivery. - Use Conventional Commits for every commit. - Before pushing, run `npm ci && npm run quality` on `HEAD` in the exact checkout you are about to push. `quality` mirrors the checks in `.github/workflows/quality.yaml`. + +- Skill validation rules are in `tools/skill-validator.md`.