fix: apply skill validator fixes to bmad-edit-prd

- Remove name/description from step file frontmatter (STEP-06)
- Remove intra-skill path variables, inline references (PATH-04, WF-03)
- Fix broken steps-v path in step-e-03 to use {project-root} var (PATH-01)
- Add missing partyModeWorkflow definition to step-e-02 (REF-01)
- Fix bare filename reference in step-e-04 to use ./ prefix (PATH-01)
- Remove redundant parenthetical path hints from step references

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-03-14 17:15:46 -06:00
parent 6c83482513
commit 63972eaa6c
6 changed files with 12 additions and 35 deletions

View File

@ -1,9 +1,4 @@
--- ---
name: 'step-e-01-discovery'
description: 'Discovery & Understanding - Understand what user wants to edit and detect PRD format'
# File references (ONLY variables used in this step)
altStepFile: './step-e-01b-legacy-conversion.md'
prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md' prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md'
advancedElicitationTask: 'skill:bmad-advanced-elicitation' advancedElicitationTask: 'skill:bmad-advanced-elicitation'
partyModeWorkflow: '{project-root}/_bmad/core/workflows/bmad-party-mode/workflow.md' partyModeWorkflow: '{project-root}/_bmad/core/workflows/bmad-party-mode/workflow.md'
@ -190,7 +185,7 @@ Display: "**Edit Requirements Understood**
**Proceeding to deep review and analysis...**" **Proceeding to deep review and analysis...**"
Read fully and follow: next step (step-e-02-review.md) Read fully and follow: ./step-e-02-review.md
**IF PRD is Legacy (Non-Standard) AND no validation report:** **IF PRD is Legacy (Non-Standard) AND no validation report:**
@ -217,7 +212,7 @@ Present MENU OPTIONS below for user selection
#### Menu Handling Logic: #### Menu Handling Logic:
- IF C (Convert): Read fully and follow: {altStepFile} (step-e-01b-legacy-conversion.md) - IF C (Convert): Read fully and follow: ./step-e-01b-legacy-conversion.md
- IF E (Edit As-Is): Display "Proceeding with edits..." then load next step - IF E (Edit As-Is): Display "Proceeding with edits..." then load next step
- IF X (Exit): Display summary and exit - IF X (Exit): Display summary and exit
- IF Any other: help user, then redisplay menu - IF Any other: help user, then redisplay menu

View File

@ -1,9 +1,4 @@
--- ---
name: 'step-e-01b-legacy-conversion'
description: 'Legacy PRD Conversion Assessment - Analyze legacy PRD and propose conversion strategy'
# File references (ONLY variables used in this step)
nextStepFile: './step-e-02-review.md'
prdFile: '{prd_file_path}' prdFile: '{prd_file_path}'
prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md' prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md'
--- ---
@ -182,7 +177,7 @@ Edit goals: {summary}
**Proceeding to deep review...**" **Proceeding to deep review...**"
Read fully and follow: {nextStepFile} (step-e-02-review.md) Read fully and follow: ./step-e-02-review.md
--- ---

View File

@ -1,13 +1,9 @@
--- ---
name: 'step-e-02-review'
description: 'Deep Review & Analysis - Thoroughly review existing PRD and prepare detailed change plan'
# File references (ONLY variables used in this step)
nextStepFile: './step-e-03-edit.md'
prdFile: '{prd_file_path}' prdFile: '{prd_file_path}'
validationReport: '{validation_report_path}' # If provided validationReport: '{validation_report_path}' # If provided
prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md' prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md'
advancedElicitationTask: 'skill:bmad-advanced-elicitation' advancedElicitationTask: 'skill:bmad-advanced-elicitation'
partyModeWorkflow: '{project-root}/_bmad/core/workflows/bmad-party-mode/workflow.md'
--- ---
# Step E-2: Deep Review & Analysis # Step E-2: Deep Review & Analysis
@ -205,7 +201,7 @@ Display: "**Change Plan Approved**
**Proceeding to edit step...**" **Proceeding to edit step...**"
Read fully and follow: {nextStepFile} (step-e-03-edit.md) Read fully and follow: ./step-e-03-edit.md
### 7. Present MENU OPTIONS (If User Wants Discussion) ### 7. Present MENU OPTIONS (If User Wants Discussion)
@ -222,7 +218,7 @@ Read fully and follow: {nextStepFile} (step-e-03-edit.md)
- IF A: Read fully and follow: {advancedElicitationTask}, then return to discussion - IF A: Read fully and follow: {advancedElicitationTask}, then return to discussion
- IF P: Read fully and follow: {partyModeWorkflow}, then return to discussion - IF P: Read fully and follow: {partyModeWorkflow}, then return to discussion
- IF C: Document approval, then load {nextStepFile} - IF C: Document approval, then load ./step-e-03-edit.md
- IF Any other: discuss, then redisplay menu - IF Any other: discuss, then redisplay menu
--- ---

View File

@ -1,11 +1,7 @@
--- ---
name: 'step-e-03-edit'
description: 'Edit & Update - Apply changes to PRD following approved change plan'
# File references (ONLY variables used in this step)
nextStepFile: './step-e-04-complete.md'
prdFile: '{prd_file_path}' prdFile: '{prd_file_path}'
prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md' prdPurpose: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/data/prd-purpose.md'
validationWorkflow: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/steps-v/step-v-01-discovery.md'
--- ---
# Step E-3: Edit & Update # Step E-3: Edit & Update
@ -211,7 +207,7 @@ Display:
### 8. Present MENU OPTIONS ### 8. Present MENU OPTIONS
**[V] Run Validation** - Execute full validation workflow (steps-v/step-v-01-discovery.md) **[V] Run Validation** - Execute full validation workflow
**[S] Summary Only** - End with summary of changes (no validation) **[S] Summary Only** - End with summary of changes (no validation)
**[A] Adjust** - Make additional edits **[A] Adjust** - Make additional edits
**[X] Exit** - Exit edit workflow **[X] Exit** - Exit edit workflow
@ -223,7 +219,7 @@ Display:
#### Menu Handling Logic: #### Menu Handling Logic:
- IF V (Validate): Display "Starting validation workflow..." then read fully and follow: steps-v/step-v-01-discovery.md - IF V (Validate): Display "Starting validation workflow..." then read fully and follow: {validationWorkflow}
- IF S (Summary): Present edit summary and exit - IF S (Summary): Present edit summary and exit
- IF A (Adjust): Accept additional requirements, loop back to editing - IF A (Adjust): Accept additional requirements, loop back to editing
- IF X (Exit): Display summary and exit - IF X (Exit): Display summary and exit

View File

@ -1,8 +1,4 @@
--- ---
name: 'step-e-04-complete'
description: 'Complete & Validate - Present options for next steps including full validation'
# File references (ONLY variables used in this step)
prdFile: '{prd_file_path}' prdFile: '{prd_file_path}'
validationWorkflow: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/steps-v/step-v-01-discovery.md' validationWorkflow: '{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-prd/steps-v/step-v-01-discovery.md'
--- ---
@ -120,14 +116,14 @@ Display:
- Display: "This will run all 13 validation checks on the updated PRD." - Display: "This will run all 13 validation checks on the updated PRD."
- Display: "Preparing to validate: {prd_file_path}" - Display: "Preparing to validate: {prd_file_path}"
- Display: "**Proceeding to validation...**" - Display: "**Proceeding to validation...**"
- Read fully and follow: {validationWorkflow} (steps-v/step-v-01-discovery.md) - Read fully and follow: {validationWorkflow}
- Note: This hands off to the validation workflow which will run its complete 13-step process - Note: This hands off to the validation workflow which will run its complete 13-step process
- **IF E (Edit More):** - **IF E (Edit More):**
- Display: "**Additional Edits**" - Display: "**Additional Edits**"
- Ask: "What additional edits would you like to make?" - Ask: "What additional edits would you like to make?"
- Accept input, then display: "**Returning to edit step...**" - Accept input, then display: "**Returning to edit step...**"
- Read fully and follow: step-e-03-edit.md again - Read fully and follow: ./step-e-03-edit.md again
- **IF S (Summary):** - **IF S (Summary):**
- Display detailed summary including: - Display detailed summary including:

View File

@ -1,6 +1,5 @@
--- ---
main_config: '{project-root}/_bmad/bmm/config.yaml' main_config: '{project-root}/_bmad/bmm/config.yaml'
editWorkflow: './steps-e/step-e-01-discovery.md'
--- ---
# PRD Edit Workflow # PRD Edit Workflow
@ -61,4 +60,4 @@ Load and read full config from {main_config} and resolve:
Prompt for PRD path: "Which PRD would you like to edit? Please provide the path to the PRD.md file." Prompt for PRD path: "Which PRD would you like to edit? Please provide the path to the PRD.md file."
Then read fully and follow: `{editWorkflow}` (steps-e/step-e-01-discovery.md) Then read fully and follow: `./steps-e/step-e-01-discovery.md`