ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: add MANDATORY story verification with hard blockers in workflow.md

This commit is contained in:
Jonah Schulte 2026-01-26 21:21:30 -05:00
parent cdf25d1591
commit 5e892fe43a
1 changed files with 61 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
src/modules/bmm/workflows/4-implementation/super-dev-pipeline/workflow.md
View File

@ -187,41 +187,86 @@ Task({
## Final Verification (Main Orchestrator) ## Final Verification (Main Orchestrator)
**After all agents complete, verify:** 🚨 **CRITICAL: This verification is MANDATORY. DO NOT skip.** 🚨
**After all agents complete, the MAIN ORCHESTRATOR must run this verification:**
```bash ```bash
# 1. Check git commits echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
echo "🔍 FINAL VERIFICATION (MANDATORY)"
echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
# 1. Check git commits exist
echo "Checking git commits..."
git log --oneline -3 | grep "{{story_key}}" git log --oneline -3 | grep "{{story_key}}"
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
echo "❌ FAILED: No commit found" echo "❌ FAILED: No commit found for {{story_key}}"
echo "The Fixer agent did not commit changes."
exit 1 exit 1
fi fi
echo "✅ Git commit found"
# 2. Check story checkboxes # 2. Check story file has checked tasks (ABSOLUTE BLOCKER)
before=$(git show HEAD~1:{{story_file}} | grep -c '^- \[x\]') echo "Checking story file updates..."
after=$(grep -c '^- \[x\]' {{story_file}}) CHECKED_COUNT=$(grep -c '^- \[x\]' {{story_file}})
if [ $after -le $before ]; then echo "Checked tasks: $CHECKED_COUNT"
echo "❌ FAILED: Checkboxes not updated"
if [ "$CHECKED_COUNT" -eq 0 ]; then
echo ""
echo "❌ BLOCKER: Story file has ZERO checked tasks"
echo ""
echo "This means the Fixer agent did NOT update the story file."
echo "The story CANNOT be marked complete without checked tasks."
echo ""
echo "You must:"
echo " 1. Read the git commit to see what was built"
echo " 2. Read the story Tasks section"
echo " 3. Use Edit tool to check off completed tasks"
echo " 4. Fill in Dev Agent Record"
echo " 5. Verify with grep"
echo " 6. Re-run this verification"
echo ""
exit 1 exit 1
fi fi
echo "✅ Story file has $CHECKED_COUNT checked tasks"
# 3. Check sprint-status # 3. Check Dev Agent Record filled
git diff HEAD~1 {{sprint_status}} | grep "{{story_key}}: done" echo "Checking Dev Agent Record..."
RECORD_FILLED=$(grep -A 20 "^### Dev Agent Record" {{story_file}} | grep -c "Agent Model")
if [ "$RECORD_FILLED" -eq 0 ]; then
echo "❌ BLOCKER: Dev Agent Record NOT filled"
echo "The Fixer agent did not document what was built."
exit 1
fi
echo "✅ Dev Agent Record filled"
# 4. Check sprint-status updated
echo "Checking sprint-status..."
git diff HEAD~1 {{sprint_status}} | grep "{{story_key}}"
if [ $? -ne 0 ]; then if [ $? -ne 0 ]; then
echo "❌ FAILED: Sprint status not updated" echo "❌ FAILED: Sprint status not updated for {{story_key}}"
exit 1 exit 1
fi fi
echo "✅ Sprint status updated"
# 4. Check Inspector output for test evidence # 5. Check test evidence (optional - may have test failures)
grep -E "PASS|tests.*passing" inspector_output.txt echo "Checking test evidence..."
if [ $? -ne 0 ]; then if [ -f "inspector_output.txt" ]; then
echo "❌ FAILED: No test evidence" grep -E "PASS|tests.*passing" inspector_output.txt && echo "✅ Tests passing"
exit 1
fi fi
echo ""
echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
echo "✅ STORY COMPLETE - All verifications passed" echo "✅ STORY COMPLETE - All verifications passed"
echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
``` ```
**IF VERIFICATION FAILS:**
- DO NOT mark story as "done"
- DO NOT proceed to next story
- FIX the failure immediately
- Re-run verification until it passes
--- ---
## Benefits Over Single-Agent ## Benefits Over Single-Agent