From c90bdce306bfc751c7a823b77ce57016c0df9ee5 Mon Sep 17 00:00:00 2001 From: Can Tecim Date: Fri, 3 Apr 2026 04:48:01 +0700 Subject: [PATCH 1/5] refactor: allow dev-story skill to modify Review Findings todo items --- src/bmm-skills/4-implementation/bmad-dev-story/workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md index 4164479c3..ecd2666ad 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md +++ b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md @@ -5,7 +5,7 @@ **Your Role:** Developer implementing the story. - Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} - Generate all documents in {document_output_language} -- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, and Status +- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, Review Findings, and Status - Execute ALL steps in exact order; do NOT skip steps - Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction. - Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 6 decides completion. From 02a8c203c67b888e42179a9c4a1f47d2df81c4c5 Mon Sep 17 00:00:00 2001 From: Can Tecim Date: Sun, 19 Apr 2026 21:48:20 +0700 Subject: [PATCH 2/5] refactor: fix findings section in step-04-present.md Updated the instructions for writing findings in the story file to specify a new subsection for follow-ups. --- .../4-implementation/bmad-code-review/steps/step-04-present.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md b/src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md index c495d4981..10452bccf 100644 --- a/src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md +++ b/src/bmm-skills/4-implementation/bmad-code-review/steps/step-04-present.md @@ -18,7 +18,7 @@ If zero findings remain after triage (all dismissed or none raised): state that ### 2. Write findings to the story file -If `{spec_file}` exists and contains a Tasks/Subtasks section, append a `### Review Findings` subsection. Write all findings in this order: +If `{spec_file}` exists and contains a Tasks/Subtasks section, append a `### Review Follow-ups (AI)` subsection if not exists already. Append all findings in this order: 1. **`decision-needed`** findings (unchecked): `- [ ] [Review][Decision] — <Detail>` From e67672ae38bfc9451e402954eea0500888589ba7 Mon Sep 17 00:00:00 2001 From: Can Tecim <can.tecim@gmail.com> Date: Sun, 19 Apr 2026 21:49:23 +0700 Subject: [PATCH 3/5] refactor: update dev-story workflow instructions --- src/bmm-skills/4-implementation/bmad-dev-story/workflow.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md index ecd2666ad..71da8eabf 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md +++ b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md @@ -5,10 +5,10 @@ **Your Role:** Developer implementing the story. - Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} - Generate all documents in {document_output_language} -- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, Review Findings, and Status +- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, and Status - Execute ALL steps in exact order; do NOT skip steps - Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction. -- Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 6 decides completion. +- Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 8 decides completion. - User skill level ({user_skill_level}) affects conversation style ONLY, not code updates. --- @@ -47,7 +47,7 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: <critical>Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction.</critical> - <critical>Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 6 decides completion.</critical> + <critical>Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 8 decides completion.</critical> <critical>User skill level ({user_skill_level}) affects conversation style ONLY, not code updates.</critical> <step n="1" goal="Find next ready story and load it" tag="sprint-status"> From 84bf1b7bbaa9b19d1071806e97780fce495d4255 Mon Sep 17 00:00:00 2001 From: Can Tecim <can.tecim@gmail.com> Date: Sun, 19 Apr 2026 21:53:23 +0700 Subject: [PATCH 4/5] refactor: allow 'Marking Review Follow-ups' Updated instructions to include 'Marking Review Follow-ups' in the modification areas. --- src/bmm-skills/4-implementation/bmad-dev-story/workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md index 71da8eabf..51f69d431 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md +++ b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md @@ -5,7 +5,7 @@ **Your Role:** Developer implementing the story. - Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} - Generate all documents in {document_output_language} -- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, and Status +- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes, Marking Review Follow-ups), File List, Change Log, and Status - Execute ALL steps in exact order; do NOT skip steps - Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction. - Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 8 decides completion. From 979450738492b9c66a63ef2e760f48a10464c42b Mon Sep 17 00:00:00 2001 From: Can Tecim <can.tecim@gmail.com> Date: Sun, 19 Apr 2026 22:07:27 +0700 Subject: [PATCH 5/5] fix: update allowed modifications --- src/bmm-skills/4-implementation/bmad-dev-story/workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md index 51f69d431..e6c162da2 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md +++ b/src/bmm-skills/4-implementation/bmad-dev-story/workflow.md @@ -5,7 +5,7 @@ **Your Role:** Developer implementing the story. - Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} - Generate all documents in {document_output_language} -- Only modify the story file in these areas: Tasks/Subtasks checkboxes, Dev Agent Record (Debug Log, Completion Notes, Marking Review Follow-ups), File List, Change Log, and Status +- Only modify the story file in these areas: Tasks/Subtasks checkboxes (including Review Follow-ups (AI)), Dev Agent Record (Debug Log, Completion Notes), File List, Change Log, and Status - Execute ALL steps in exact order; do NOT skip steps - Absolutely DO NOT stop because of "milestones", "significant progress", or "session boundaries". Continue in a single execution until the story is COMPLETE (all ACs satisfied and all tasks/subtasks checked) UNLESS a HALT condition is triggered or the USER gives other instruction. - Do NOT schedule a "next session" or request review pauses unless a HALT condition applies. Only Step 8 decides completion.