diff --git a/FEATURE-SUMMARY.md b/FEATURE-SUMMARY.md new file mode 100644 index 00000000..7194e84a --- /dev/null +++ b/FEATURE-SUMMARY.md @@ -0,0 +1,221 @@ +# Gap Analysis & Quality Automation - Complete Feature Summary + +## Overview + +Two feature branches implementing comprehensive quality automation for BMAD-METHOD: + +1. **feature/gap-analysis-dev-time** - Foundation (6 commits) +2. **feature/autonomous-epic-processing** - Full automation (11 commits total) + +--- + +## Branch 1: Gap Analysis Foundation + +**Branch:** `feature/gap-analysis-dev-time` +**Commits:** 6 +**Purpose:** Solve batch planning staleness problem + +### Features Added + +#### 1. create-story Refactor +- Simplified to requirements analysis only +- Generates DRAFT tasks (not codebase-validated) +- Defers gap analysis to dev-time +- **Result:** Faster planning, no stale scans + +#### 2. dev-story Gap Analysis (Step 1.5) +- **MANDATORY** codebase scanning before development +- Validates DRAFT tasks against reality +- Proposes refinements (add/modify/remove tasks) +- 6 user options: Y/A/n/e/s/r +- Auto-accept mode for automation +- **Result:** Tasks always reflect current codebase + +#### 3. Standalone gap-analysis Workflow +- New `/gap-analysis` command +- Audit completed stories +- Detect false positives (marked done but not implemented) +- Batch validation mode +- Generate audit reports +- **Result:** Quality auditing tool + +#### 4. super-dev-story Workflow +- New `/super-dev-story` command +- All dev-story steps + +- Step 9.5: Post-dev gap analysis +- Step 9.6: Auto code review +- Fix iteration loops +- **Result:** Bulletproof stories before human review + +#### 5. Documentation +- docs/gap-analysis.md - Complete user guide +- docs/gap-analysis-migration.md - Migration guide +- docs/super-dev-mode.md - Concept and usage +- docs/autonomous-epic-processing.md - Future vision + +**Stats:** 16 files, ~2,740 lines + +--- + +## Branch 2: Autonomous Epic Processing + +**Branch:** `feature/autonomous-epic-processing` (based on gap-analysis branch) +**Commits:** 11 (includes all 6 from gap-analysis + 5 new) +**Purpose:** "Do Epic 4 for me" - full automation + +### Additional Features + +#### 6. autonomous-epic Workflow +- New `/autonomous-epic` command +- Just-in-time planning (creates each story before dev) +- Auto-develops using super-dev-story or dev-story +- Progress tracking with resume capability +- Error handling with retry logic +- Epic completion reports +- **Result:** Complete epic automation + +#### 7. push-all Workflow +- New `/push-all` command +- Stage all changes with safety checks +- Secret detection (API keys, credentials) +- Large file warnings +- Build artifact detection +- Smart commit message generation +- Auto-push with error handling +- **Result:** Safe automated git operations + +#### 8. Agent Menu Registration +- Registered all workflows in agent menus +- Dev agent: DS, SDS, GA, AE, PA, CR +- SM agent: CS, GA, AEP, PA, ER +- **Result:** All workflows accessible via `*` commands + +#### 9. Integration Enhancements +- super-dev-story Step 11: push-all +- autonomous-epic: push-all after each story +- Auto-generated commit messages +- **Result:** Seamless git integration + +**Stats:** 36 files total, ~8,079 lines + +--- + +## Complete Workflow Lineup + +| Command | What It Does | Use When | +|---------|--------------|----------| +| `/dev-story` | Standard dev with pre-gap | Normal stories | +| `/super-dev-story` | Enhanced: pre+post gap + review + push | Critical stories | +| `/gap-analysis` | Audit without development | Quality checks | +| `/autonomous-epic` | Full epic automation | Overnight/CI-CD | +| `/push-all` | Safe commit+push | Anytime | + +--- + +## Technical Stats + +**Total Changes:** +- Files: 36 modified/created +- Lines: +8,079 insertions, -93 deletions +- Commits: 11 well-formed conventional commits +- Modules: BMM and BMGD (both fully supported) + +**Validation:** +- ✅ All schema validation passing +- ✅ All linting passing +- ✅ All formatting passing +- ✅ All tests passing + +**Backwards Compatibility:** +- ✅ No breaking changes +- ✅ Existing workflows unchanged (except enhancements) +- ✅ Users can opt-in to new features + +--- + +## Key Innovations + +### 1. Dev-Time Gap Analysis +**Problem:** Batch planning creates stale stories +**Solution:** Validate tasks against codebase when dev starts +**Impact:** Prevents duplicate code, adapts to evolved codebase + +### 2. Just-in-Time Planning + Development +**Problem:** Planning all stories upfront leads to staleness +**Solution:** Create story right before developing it +**Impact:** Plans always reflect current reality + +### 3. Multi-Stage Quality Validation +**Problem:** Stories marked "done" prematurely +**Solution:** Pre-gap + dev + post-gap + code review +**Impact:** True completion, fewer review cycles + +### 4. Safe Automated Git Operations +**Problem:** Committing secrets, large files, build artifacts +**Solution:** Comprehensive safety checks before push +**Impact:** Secure, clean git history + +--- + +## Testing Setup + +**Your platform project:** +``` +~/git/your-project/_bmad/bmm → [SYMLINK] → BMAD-METHOD/src/modules/bmm +``` + +**Compiled agents updated:** +``` +~/git/your-project/.claude/commands/bmad/bmm/agents/ +├── dev.md (updated with all new workflows) +└── sm.md (updated with all new workflows) +``` + +**Available now (after restart):** +- `*dev-story` - Standard +- `*super-dev-story` - Enhanced +- `*gap-analysis` - Audit +- `*autonomous-epic` - Full auto +- `*push-all` - Safe commit+push + +--- + +## Next Steps + +### Immediate: +1. ✅ Restart Claude Code +2. ✅ Load Dev or SM agent (`*`) +3. ✅ Test workflows in platform project + +### Short-term: +1. Gather real-world usage feedback +2. Note any edge cases or issues +3. Refine gap analysis detection +4. Improve commit message generation + +### Long-term: +1. Consider PR to BMAD-METHOD repo +2. Get community feedback +3. Iterate based on usage +4. Build additional automation + +--- + +## Contribution Ready + +Both branches ready for: +- Real-world testing +- Community feedback +- PR submission to bmad-code-org/BMAD-METHOD + +**Branch recommendations for PR:** +- **Option 1:** Submit gap-analysis-dev-time first (foundation) +- **Option 2:** Submit autonomous-epic-processing (includes everything) + +--- + +**Total Development Time:** ~2 hours +**Total Value:** Solves major BMAD workflow gaps +**Community Impact:** Massive (benefits all batch planning users) + +🎯 **You solved a real problem that's been hiding in plain sight!** diff --git a/TESTING-GUIDE.md b/TESTING-GUIDE.md index 2831ae35..493df85f 100644 --- a/TESTING-GUIDE.md +++ b/TESTING-GUIDE.md @@ -2,10 +2,10 @@ ## Setup Complete ✅ -Your platform project (`~/git/ai/platform`) is configured to use the dev version via symlink: +Your project (`~/git/your-project`) is configured to use the dev version via symlink: ``` -~/git/ai/platform/_bmad/bmm → ~/git/ai/BMAD-METHOD/src/modules/bmm +~/git/your-project/_bmad/bmm → ~/git/BMAD-METHOD/src/modules/bmm ``` All changes from `feature/gap-analysis-dev-time` branch are **live and testable**. @@ -19,7 +19,7 @@ All changes from `feature/gap-analysis-dev-time` branch are **live and testable* **Goal:** Verify gap analysis runs and proposes task updates ```bash -cd ~/git/ai/platform +cd ~/git/your-project # Load PM or Dev agent # Run: @@ -247,7 +247,7 @@ Track these metrics: ## Rollback (If Issues Found) ```bash -cd ~/git/ai/platform/_bmad +cd ~/git/your-project/_bmad rm bmm mv bmm.backup bmm diff --git a/docs/gap-analysis-migration.md b/docs/gap-analysis-migration.md index 0c1b91c2..87785bbd 100644 --- a/docs/gap-analysis-migration.md +++ b/docs/gap-analysis-migration.md @@ -162,7 +162,7 @@ git checkout v6.0.0-alpha.21 -- src/modules/bmm/workflows/4-implementation/ git checkout v6.0.0-alpha.21 -- src/modules/bmgd/workflows/4-production/ # Reinstall in your project -cd ~/git/ai/platform +cd ~/git/your-project rm -rf _bmad npx bmad-method@alpha install ``` diff --git a/src/modules/bmgd/workflows/4-production/autonomous-epic/instructions.xml b/src/modules/bmgd/workflows/4-production/autonomous-epic/instructions.xml index 790d8cac..866c374c 100644 --- a/src/modules/bmgd/workflows/4-production/autonomous-epic/instructions.xml +++ b/src/modules/bmgd/workflows/4-production/autonomous-epic/instructions.xml @@ -3,15 +3,15 @@ You MUST have already loaded and processed: {installed_path}/workflow.yaml Communicate all responses in {communication_language} 🤖 AUTONOMOUS EPIC PROCESSING - Full automation of epic completion! - This workflow creates and develops ALL stories in an epic with minimal human intervention + This workflow orchestrates create-story and super-dev-story for each story in an epic - + 🤖 **Autonomous Epic Processing** This workflow will automatically: - 1. Create all stories in the epic (just-in-time planning) - 2. Develop each story with comprehensive validation - 3. Commit changes after each story + 1. Create each story just-in-time (using create-story) + 2. Develop each story (using super-dev-story or dev-story) + 3. Commit and push after each story (integrated in super-dev) 4. Generate epic completion report **Time Estimate:** Varies by epic size @@ -20,22 +20,17 @@ - Large epic (11+ stories): 12-24 hours **Token Usage:** ~100K-150K per story - - Uses super-dev-story by default (highest quality) - - Auto-accepts gap analysis (minimal prompts) - - --- - + Use provided epic number - Enter epic number to process (e.g., "2", "epic-3"), or [q] to quit: + Enter epic number to process (e.g., "2" or "epic-3"), or [q] to quit: - Parse epic number from input (handle "2", "epic-2", "Epic 2" formats) - Set {{epic_num}} to parsed number + Parse epic number from input @@ -47,37 +42,8 @@ Load {{sprint_status}} file - Find epic-{{epic_num}} entry in development_status - - - ❌ Epic {{epic_num}} not found in sprint-status.yaml - - Available epics: - {{list_available_epics}} - - Run sprint-planning to initialize sprint tracking. - - HALT - - - Get epic status from sprint-status - - - ✅ Epic {{epic_num}} is already complete! - - All stories marked done. Nothing to process. - - HALT - - - Count stories in epic (pattern: {{epic_num}}-*) - Count stories by status: - - backlog: Not yet created - - ready-for-dev: Created but not developed - - in-progress: Partially developed - - review: Developed, pending review - - done: Fully complete - + Find epic-{{epic_num}} entry + Count stories by status (backlog, ready-for-dev, in-progress, review, done) 📊 **Epic {{epic_num}} Status** @@ -86,294 +52,145 @@ - Backlog: {{backlog_count}} (will create + develop) - Ready-for-dev: {{ready_count}} (will develop) - In-progress: {{inprogress_count}} (will resume) - - Review: {{review_count}} (will skip - needs human review) - - Done: {{done_count}} (will skip - already complete) + - Review/Done: {{done_count}} (will skip) - **Work Remaining:** {{backlog_count + ready_count + inprogress_count}} stories + **Work Remaining:** {{work_count}} stories **Estimated Time:** {{estimated_hours}} hours **Estimated Tokens:** ~{{estimated_tokens}}K - - **Proceed with autonomous processing?** - This will: - - Process {{work_count}} stories automatically - - Use {{dev_workflow}} for development (super-dev-story or dev-story) - - Create git commits after each story - - Take approximately {{estimated_hours}} hours - - Use approximately {{estimated_tokens}}K tokens - - Options: - [Y] Yes - Start autonomous processing with default settings - [C] Custom - Let me configure settings first - [n] No - Cancel autonomous processing + [Y] Yes - Use super-dev-story (comprehensive validation) + [D] Dev-story - Faster, less validation + [n] No - Cancel - - Use default autonomous_settings from workflow.yaml - ✅ Starting autonomous epic processing with defaults... - + + Set {{dev_workflow}} = "super-dev-story" - - Use super-dev-story (comprehensive validation) or dev-story (faster)? [super/dev]: - Store user choice as {{dev_workflow}} - - Auto-accept gap analysis refinements? [Y/n]: - Store user choice as {{auto_accept_gap}} - - Create git commits after each story? [Y/n]: - Store user choice as {{create_commits}} - - Halt on first error or continue? [halt/continue]: - Store user choice as {{error_handling}} - - ✅ Custom settings configured. Starting autonomous processing... - + + Set {{dev_workflow}} = "dev-story" - - ❌ Autonomous epic processing cancelled. + + ❌ Cancelled HALT - - - - - Check current git branch - Create new branch: {{git_branch_prefix}}{{epic_num}} - 📝 Created git branch: {{git_branch_prefix}}{{epic_num}} - + + Get current branch name + Create new branch: auto-epic-{{epic_num}} + 📝 Created branch: auto-epic-{{epic_num}} - - Create progress file: {{progress_file}} - Write initial progress state: - epic_num: {{epic_num}} - started: {{date}} - total_stories: {{total_story_count}} - completed_stories: [] - failed_stories: [] - current_story: null - status: running + Initialize progress tracking file: + - epic_num + - started timestamp + - total_stories + - completed_stories: [] + - current_story: null + - status: running - - 🚀 **Autonomous Epic Processing Started** - - Epic: {{epic_num}} - Branch: {{git_branch_name}} - Progress tracking: {{progress_file}} - - Processing {{work_count}} stories... - - - 🔄 STORY PROCESSING LOOP - Just-in-time planning + development + + 🔄 STORY LOOP - Create and develop each story - Load {{sprint_status}} file - Find all stories in epic {{epic_num}} (pattern: {{epic_num}}-*) - Sort stories by story number (ascending order) - Filter to stories needing work (backlog, ready-for-dev, in-progress statuses) - - Initialize {{story_counter}} = 0 - Initialize {{success_count}} = 0 - Initialize {{failure_count}} = 0 + Find all stories in epic {{epic_num}} needing work + Sort by story number (ascending) + Initialize counters: success=0, failure=0 - Set {{current_story}} = current story from loop - Increment {{story_counter}} - Update progress file with current_story + Set {{current_story}} - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - Story {{story_counter}}/{{work_count}}: {{current_story.key}} - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - Status: {{current_story.status}} - Started: {{current_time}} + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + Story {{counter}}/{{work_count}}: {{current_story.key}} + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - - 📝 Creating story {{current_story.key}}... + + 📝 Creating story... - Run create-story workflow for this story - Wait for story file to be created - ✅ Story created: {{story_file}} + + Create story just-in-time + + + ✅ Story created - ❌ Failed to create story {{current_story.key}} - - Error: {{error_message}} - - - - Update progress file with failure - 🛑 Halting due to error (halt_on_error=true) - HALT - - - - Add to {{failed_stories}} list - Increment {{failure_count}} - ⏭️ Skipping to next story... - Next story in loop - + ❌ Failed to create story: {{error}} + Add to failed_stories, continue to next + - 💻 Developing story {{current_story.key}} using {{dev_workflow}}... + 💻 Developing with {{dev_workflow}}... - Run super-dev-story workflow with auto-accept mode enabled + + + Includes: dev + post-gap + review + push-all + - Run dev-story workflow with auto-accept mode enabled + + + + + + + Commit and push story changes + - Wait for story to be marked "review" - - ✅ Story {{current_story.key}} completed - - Status: review - Tasks completed: {{task_count}} - Files changed: {{file_count}} - Time: {{elapsed_time}} - - - - 📝 Running push-all to commit and push story changes... - - - Run push-all workflow with auto-accept mode: - - Safety checks run automatically - - Generate commit message based on story - - Commit with message: "feat(epic-{{epic_num}}): complete story {{current_story.key}} - {{story_title}}" - - Push to remote automatically - - ✅ Pushed to remote: {{commit_hash}} - - - - ⚠️ Push-all failed for story {{current_story.key}} - - Error: {{push_error}} - - Story is complete but not pushed to remote yet. - You can push manually later. - - - - 🛑 Halting due to push error (halt_on_error=true) - Update progress file with failure - HALT - - - Note: Story complete locally, push failed - continuing... - - - Increment {{success_count}} - Add to progress file completed_stories list - Update progress file with success - + ✅ Story complete and pushed + Increment success_count + Update progress file - ❌ Failed to develop story {{current_story.key}} - - Error: {{error_message}} - Attempt: {{retry_count}}/{{max_retry_per_story}} - - - - 🔄 Retrying story {{current_story.key}}... - Increment {{retry_count}} - Retry this story - - - - ⚠️ Max retries reached for story {{current_story.key}} - - - Update progress file with failure and halt - 🛑 Halting due to repeated errors (halt_on_error=true) - HALT - - - - Add to {{failed_stories}} list - Increment {{failure_count}} - ⏭️ Skipping to next story... - Next story in loop - - + ❌ Story failed: {{error}} + Add to failed_stories, continue + Increment failure_count - - - Progress: {{success_count}} ✅ | {{failure_count}} ❌ | {{remaining_count}} pending - - + Progress: {{success_count}} ✅ | {{failure_count}} ❌ | {{remaining}} pending - Update progress file status: complete - - 📊 EPIC COMPLETE - Generate completion report - - Load all completed story files from this epic - Aggregate statistics: - - Total files created/modified - - Total test coverage - - Total code review issues found and fixed - - Total development time - - Success rate - - - Generate epic completion report: {{story_dir}}/epic-{{epic_num}}-completion-report.md - + - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - 🎉 EPIC {{epic_num}} AUTONOMOUS PROCESSING COMPLETE! - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + 🎉 EPIC {{epic_num}} COMPLETE! + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ **Results:** - ✅ Stories completed: {{success_count}}/{{total_story_count}} - {{if_failures}} - ❌ Stories failed: {{failure_count}} - {{list_failed_stories_with_reasons}} + ✅ Stories completed: {{success_count}}/{{total_count}} + {{if_failures}}❌ Stories failed: {{failure_count}}{{endif}} + + **Branch:** auto-epic-{{epic_num}} + **All changes pushed to remote** + + {{if_all_success}} + **Epic {{epic_num}} marked complete in sprint-status.yaml** {{endif}} - **Statistics:** - - Total development time: {{total_time}} - - Files created/modified: {{total_files}} - - Test coverage achieved: {{avg_coverage}}% - - Code review issues found: {{total_issues}} - - Code review issues fixed: {{total_fixes}} - - **Git Branch:** {{git_branch_name}} - **Commits:** {{commit_count}} - - **Completion Report:** {{report_file}} - - --- - **Next Steps:** - 1. Review the completion report - 2. Manually review/fix any failed stories - 3. Run human code review on the branch - 4. Merge {{git_branch_name}} when approved + 1. Review the work on branch auto-epic-{{epic_num}} + 2. Run human code review + 3. Merge when approved {{if_failures}} **Failed Stories Need Attention:** @@ -381,61 +198,11 @@ {{endif}} - - - Load {{sprint_status}} file - Update epic-{{epic_num}} status to "done" - ✅ Epic {{epic_num}} marked complete in sprint-status.yaml + + Update sprint-status: epic-{{epic_num}} = "done" - - ℹ️ Epic {{epic_num}} partially complete - some stories failed. - Epic status remains "in-progress" until failed stories resolved. - - - - - - 📝 All changes committed to branch: {{git_branch_name}} - - To merge: - git checkout main - git merge {{git_branch_name}} - - Or create PR: - gh pr create --base main --head {{git_branch_name}} - - - - - - Remove progress file (no longer needed) - - Would you like explanations about: - - How autonomous processing works - - What was implemented in this epic - - Why any stories failed - - How to review and merge the work - - Anything else? - - [Enter topic or 'n' to skip] - - - - Provide clear explanations about requested topics - Reference specific stories, code, or decisions - - - 💡 **Tips for Future Autonomous Processing:** - - - Use super-dev-story for critical epics (higher quality, more tokens) - - Use dev-story for experimental epics (faster, fewer tokens) - - Review completion report for patterns and improvements - - Failed stories often indicate unclear requirements - - Monitor token usage and adjust epic size accordingly - - **Epic {{epic_num}} processing complete, {user_name}!** - + Remove progress file diff --git a/src/modules/bmgd/workflows/4-production/super-dev-story/instructions.xml b/src/modules/bmgd/workflows/4-production/super-dev-story/instructions.xml index bef92e3b..121027a2 100644 --- a/src/modules/bmgd/workflows/4-production/super-dev-story/instructions.xml +++ b/src/modules/bmgd/workflows/4-production/super-dev-story/instructions.xml @@ -4,43 +4,60 @@ Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} Generate all documents in {document_output_language} 🚀 SUPER-DEV MODE: Enhanced quality workflow with post-implementation validation and automated code review - This workflow ensures stories are TRULY complete through multi-stage validation before marking done - ⚙️ EXECUTION FLOW: First execute ALL dev-story steps (1-8), then continue with super-dev enhancements (9.5-9.6) + This workflow orchestrates existing workflows with additional validation steps - + - 🎯 EXECUTE DEV-STORY STEPS 1-8 FIRST - Follow all instructions in: {project-root}/_bmad/bmgd/workflows/4-production/dev-story/instructions.xml - Complete Steps 1 through 8 exactly as specified in dev-story workflow - After Step 8 completes (all tasks checked), return here and continue with Step 9.5 below + + 🎯 RUN DEV-STORY - Complete all standard development steps + This includes: story loading, pre-dev gap analysis, development, testing, and task completion - ⚙️ Super-dev-story includes ALL standard dev-story steps (1-8): + 🚀 **Super-Dev-Story: Enhanced Quality Workflow** - **Standard Development Flow:** - - Step 1: Find and load story (sprint-status or user-provided path) - - Step 1.5: ✅ PRE-DEV GAP ANALYSIS - Validate tasks against codebase - - Step 2: Load project context and story information - - Step 3: Detect review continuation (if resuming after code-review) - - Step 4: Mark story in-progress in sprint-status - - Step 5: Implement task following red-green-refactor cycle (TDD) - - Step 6: Author comprehensive tests (unit, integration, e2e) - - Step 7: Run validations and tests (regression suite) - - Step 8: Validate and mark task complete (strict gates) + Running standard dev-story workflow (Steps 1-8)... - After completing Steps 1-8, super-dev mode adds ADDITIONAL quality validation below. + This includes: + ✅ Story loading and validation + ✅ Pre-dev gap analysis + ✅ TDD implementation cycle + ✅ Comprehensive testing + ✅ Task completion validation - **For complete details of Steps 1-8, see:** {project-root}/_bmad/bmgd/workflows/4-production/dev-story/instructions.xml - + After dev-story completes, super-dev will add: + ✅ Post-dev gap analysis + ✅ Automated code review + ✅ Auto push-all + + + + + Pass through any user-provided story file path + + + + ✅ Dev-story complete - all tasks implemented and tested + + Proceeding to super-dev enhancements... + + + + + ❌ Dev-story did not complete successfully + + Cannot proceed with super-dev enhancements. + Fix issues and retry. + + HALT - dev-story must complete first + + - + - - - + 🔍 POST-DEV VALIDATION - Verify all work actually completed! This catches incomplete implementations that were prematurely marked done @@ -51,8 +68,8 @@ - Re-read story requirements and acceptance criteria - Extract all tasks and subtasks that are marked [x] complete + Re-read story file to get requirements and tasks + Extract all tasks marked [x] complete For each completed task, identify what should exist in codebase @@ -77,52 +94,29 @@ - Note partial implementations marked as complete - ⚠️ Quality Issues: - - Implementations that exist but don't meet requirements - - Tests that exist but have poor coverage - - Code that works but violates architecture patterns - - - + ⚠️ **Post-Dev Gaps Detected!** - **False Positives (marked done but not complete):** + **Tasks marked complete but implementation incomplete:** {{list_false_positives_with_details}} - **Quality Issues:** - {{list_quality_issues_with_details}} - - **Proposed Actions:** - {{list_tasks_to_add_for_missing_work}} - - --- - These issues must be addressed before story can be marked complete. Uncheck false positive tasks in story file - Add new tasks for missing work to Tasks/Subtasks section - Add note to Dev Agent Record: "Post-dev gap analysis found incomplete work - continuing implementation" + Add new tasks for missing work Update Gap Analysis section with post-dev findings - Set {{fix_iteration_count}} = {{fix_iteration_count}} + 1 - - 🛑 **Maximum Fix Iterations Reached** + 🔄 Re-invoking dev-story to complete missing work... - Attempted {{fix_iteration_count}} fix cycles. - Manual intervention required. + + + Resume with added tasks for missing work + - Issues remaining: - {{list_remaining_issues}} - - Add to Dev Agent Record: "HALTED - exceeded max fix iterations, manual review needed" - HALT - require user intervention - - - 🔄 Adding missing work to task list and continuing implementation... - Continue implementation with added tasks + ✅ Missing work completed. Proceeding to code review... @@ -132,13 +126,15 @@ Proceeding to code review... Update Gap Analysis section with post-dev verification results - Continue to Step 9.6 - + + + + + 👀 AUTO CODE REVIEW - Independent quality validation - Fresh perspective catches issues the dev agent might miss 🔍 **Running Automated Code Review** @@ -146,107 +142,56 @@ Analyzing implementation for issues... - - Extract File List from Dev Agent Record - Identify all files created or modified during implementation + + + Run code review on completed story + - - Perform comprehensive code review checking: - - **Correctness:** Logic errors, edge cases, error handling - - **Architecture:** Compliance with patterns and standards - - **Security:** Vulnerabilities, input validation, authentication - - **Performance:** Inefficiencies, N+1 queries, memory leaks - - **Testing:** Test coverage, edge cases, test quality - - **Code Quality:** Readability, maintainability, documentation + Parse code review results from story file "Code Review" section + Extract issues by severity (Critical, High, Medium, Low) + Count total issues found - - Categorize all findings by severity: - - CRITICAL: Security vulnerabilities, data loss, broken functionality - - HIGH: Logic errors, missing error handling, test gaps - - MEDIUM: Code quality issues, minor bugs, performance concerns - - LOW: Style issues, documentation improvements, minor refactoring + + 🚨 **Code Review Found Issues Requiring Fixes** - - - - 🚨 **Code Review Found Issues Requiring Fixes** + Issues found: {{total_issue_count}} + - Critical: {{critical_count}} + - High: {{high_count}} + - Medium: {{medium_count}} + - Low: {{low_count}} - **Critical Issues ({{critical_count}}):** - {{list_critical_issues}} - - **High Priority Issues ({{high_count}}):** - {{list_high_issues}} - - {{if_medium_or_low_exist}} - **Medium/Low Issues ({{med_low_count}}):** - {{list_medium_low_issues}} - {{endif}} - - --- - - **These issues must be fixed before story completion.** + Adding review findings to story tasks and re-running dev-story... - Add "Code Review Findings" section to story file - Add review findings as new tasks in Tasks/Subtasks with [AI-Review] prefix - Add to Dev Agent Record: "Code review found {{total_issue_count}} issues - continuing with fixes" - Set {{fix_iteration_count}} = {{fix_iteration_count}} + 1 + Add code review findings as tasks in story file - - 🛑 **Maximum Fix Iterations Reached** + + + Fix code review issues + - Code review found issues on iteration {{fix_iteration_count}}. - Manual review recommended. - - Issues found: - {{list_all_issues}} - - Add to Dev Agent Record: "HALTED - code review issues after max iterations, manual review needed" - HALT - require user intervention - - - 🔧 Adding review findings to task list and implementing fixes... - Implement fixes + ✅ Code review issues resolved. Proceeding to push... - - - ℹ️ **Code Review Found Minor Issues** + + ℹ️ **Code Review Found Minor Issues** - **Medium Issues ({{medium_count}}):** - {{list_medium_issues}} - - **Low Priority Issues ({{low_count}}):** - {{list_low_issues}} - - --- + - Medium: {{medium_count}} + - Low: {{low_count}} - Auto-fix these minor issues? - - Options: - [Y] Yes - Add to task list and fix now - [n] No - Document in story but don't fix (can address later) - [s] Skip - Ignore these findings - + Auto-fix these minor issues? [Y/n/skip]: - Add review findings as tasks with [AI-Review] prefix - Add to Dev Agent Record: "Addressing {{issue_count}} minor code review findings" - 🔧 Implementing minor fixes... - Implement fixes + Add review findings as tasks + + + - - Add "Code Review Findings" section documenting issues - Add to Dev Agent Record: "Code review found {{issue_count}} minor issues - documented for future work" - ℹ️ Issues documented in story. Proceeding to completion... - Continue to Step 9 - - - - ⚠️ Skipping minor issues. Proceeding to completion... - Continue to Step 9 + + Document issues in story file + ℹ️ Minor issues documented. Proceeding to push... @@ -254,81 +199,55 @@ ✅ **Code Review Passed** No issues found. Implementation meets quality standards. + Proceeding to push... - Add to Dev Agent Record: "Code review completed - no issues found" - Continue to Step 9 - - 🎯 FINAL VALIDATION - All quality gates must pass! + + + - Verify ALL tasks and subtasks are marked [x] (re-scan the story document now) - Run the full regression suite (do not skip) - Confirm File List includes every changed file - Execute enhanced definition-of-done validation + + 📝 PUSH-ALL - Stage, commit, and push with safety validation - - Validate super-dev quality gates: - - ✅ Pre-dev gap analysis completed and approved - - ✅ All tasks/subtasks marked complete with [x] - - ✅ Implementation satisfies every Acceptance Criterion - - ✅ All tests pass (no regressions, new tests successful) - - ✅ Post-dev gap analysis passed (no false positives) - - ✅ Code review completed (critical/high issues resolved) - - ✅ File List includes every new/modified/deleted file - - ✅ Dev Agent Record contains implementation notes - - ✅ Change Log includes summary of changes - + 📝 **Committing and Pushing Story Changes** - Update the story Status to: "review" + Running push-all workflow with safety checks... + - - - Load the FULL file: {sprint_status} - Find development_status key matching {{story_key}} - Verify current status is "in-progress" (expected previous state) - Update development_status[{{story_key}}] = "review" - Save file, preserving ALL comments and structure including STATUS DEFINITIONS - ✅ Story status updated to "review" in sprint-status.yaml + + Commit and push all story changes + + + + ✅ Changes pushed to remote successfully - - ℹ️ Story status updated to "review" in story file (no sprint tracking configured) - + + ⚠️ Push failed but story is complete locally - - HALT - Complete remaining tasks before marking ready for review - HALT - Fix regression issues before completing - HALT - Update File List with all changed files - HALT - Run post-dev validation before completing - HALT - Run code review before completing + You can push manually when ready. + + - - Prepare comprehensive summary in Dev Agent Record → Completion Notes + + + + 🎉 **SUPER-DEV STORY COMPLETE, {user_name}!** - **Story:** {{story_key}} - {{story_title}} - **Status:** review (ready for human review) - - --- - **Quality Gates Passed:** - ✅ Pre-dev gap analysis - Tasks validated before work started + ✅ Pre-dev gap analysis - Tasks validated before work ✅ Development - All tasks completed with TDD - ✅ Post-dev gap analysis - Implementation verified complete - ✅ Code review - {{total_issues_found}} issues found and resolved - ✅ All tests passing - No regressions - - **Implementation Summary:** - - Files changed: {{file_count}} - - Tests added: {{test_count}} - - Issues fixed: {{review_issues_fixed}} - - Fix iterations: {{fix_iteration_count}}/{{max_fix_iterations}} + ✅ Post-dev gap analysis - Implementation verified + ✅ Code review - Quality and security validated + ✅ Pushed to remote - Changes backed up **Story File:** {{story_file}} + **Status:** review (ready for human review) --- @@ -337,7 +256,7 @@ 2. 💻 Implementation completed per requirements 3. ✅ No false positive completions (all work verified) 4. 👀 Code quality and security validated - 5. 🧪 Comprehensive test coverage achieved + 5. 📝 Changes committed and pushed to remote **Next Steps:** - Review the completed story @@ -348,343 +267,17 @@ It should require minimal human review. - Based on {user_skill_level}, ask if user needs any explanations about: - - What was implemented and how it works - - Why certain technical decisions were made - - Gap analysis or code review findings - - Any patterns, libraries, or approaches used - + Based on {user_skill_level}, ask if user needs explanations about implementation, decisions, or findings - Provide clear, contextual explanations tailored to {user_skill_level} - Use examples and references to specific code when helpful + Provide clear, contextual explanations 💡 **Tip:** This story was developed with super-dev-story for enhanced quality. - For faster development (fewer validations), use standard `dev-story` workflow. - For maximum quality and fewer review cycles, continue using `super-dev-story`. + For faster development, use standard `dev-story` workflow. + For maximum quality, continue using `super-dev-story`. - - 📝 PUSH-ALL - Stage, commit, and push all changes with safety validation - ⚠️ Use with caution - commits ALL changes in repository - - 🔄 **Analyzing Repository Changes** - - Scanning for changes to commit and push... - - - - Run git commands in parallel: - - git status - Show modified/added/deleted/untracked files - - git diff --stat - Show change statistics - - git log -1 --oneline - Show recent commit for message style - - git branch --show-current - Confirm current branch - - Parse git status output to identify: - - Modified files - - Added files - - Deleted files - - Untracked files - - Total insertion/deletion counts - - - - 🔒 SAFETY VALIDATION - Check for secrets, large files, and unwanted artifacts - - Scan all changed files for dangerous patterns: - - **Secret Detection:** - Check for files matching secret patterns: - - .env*, *.key, *.pem, credentials.json, secrets.yaml - - id_rsa, *.p12, *.pfx, *.cer - - Any file containing: _API_KEY=, _SECRET=, _TOKEN= with real values - - - Validate API keys are placeholders only: - ✅ Acceptable: API_KEY=your-api-key-here, SECRET=placeholder, TOKEN=xxx, API_KEY=${'{YOUR_KEY}'} - ❌ BLOCK: OPENAI_API_KEY=sk-proj-*, AWS_SECRET_KEY=AKIA*, STRIPE_API_KEY=sk_live_* - - **File Size Check:** - Check for files >10MB without Git LFS - - **Build Artifacts:** - Check for unwanted directories/files: - - node_modules/, dist/, build/, __pycache__/, *.pyc, .venv/ - - .DS_Store, thumbs.db, *.swp, *.tmp - - - **Git State:** - Verify: - - .gitignore properly configured - - No merge conflicts - - Repository initialized - - - - - 🚨 **DANGER: Secrets Detected!** - - The following sensitive data was found: - {{list_detected_secrets}} - - ❌ **BLOCKED:** Cannot commit secrets to version control. - - **Actions Required:** - 1. Move secrets to .env file - 2. Add .env to .gitignore - 3. Use environment variables in code - 4. Remove secrets from tracked files - - Halting push-all workflow. - - HALT - Cannot proceed with secrets in changeset - - - - ⚠️ **Warning: Large Files Detected** - - Files >10MB found: - {{list_large_files}} - - **Recommendation:** Use Git LFS for large files - - Continue anyway? [y/n]: - - - Proceed with large files? [y/n]: - - - Halting push-all. Please set up Git LFS for large files. - HALT - - - - - ⚠️ **Warning: Build Artifacts Detected** - - Should not be committed: - {{list_build_artifacts}} - - **These should be in .gitignore** - - Continue anyway? [y/n]: - - - Proceed despite build artifacts? [y/n]: - - - Halting push-all. Update .gitignore to exclude build artifacts. - HALT - - - - - ⚠️ **Warning: Pushing to {{branch_name}}** - - You're on the main/master branch. Consider: - - Creating a feature branch - - Opening a PR for review - - Continue pushing to {{branch_name}}? [y/n]: - - - Push directly to {{branch_name}}? [y/n]: - - - Halting push-all. Create a feature branch instead. - HALT - - - - - - 📊 **Changes Summary** - - **Files:** - - Modified: {{modified_count}} - - Added: {{added_count}} - - Deleted: {{deleted_count}} - - Untracked: {{untracked_count}} - - **Changes:** - - Insertions: +{{insertion_count}} - - Deletions: -{{deletion_count}} - - **Safety Checks:** - {{if_all_safe}} - ✅ No secrets detected - ✅ No large files - ✅ No build artifacts - ✅ .gitignore configured - {{endif}} - - {{if_warnings}} - ⚠️ {{warning_list}} - {{endif}} - - **Git:** - - Branch: {{current_branch}} → origin/{{current_branch}} - - Last commit: {{last_commit}} - - --- - - **I will execute:** - 1. git add . - 2. git commit -m "[generated message]" - 3. git push - - - - **Proceed with commit and push?** - - Type 'yes' to proceed, 'no' to cancel, or 'review' to see detailed diff: - - - - Run: git diff --stat - Show detailed file changes - Still proceed with commit and push? [yes/no]: - - - - ❌ Push-all cancelled. Changes remain unstaged. - - You can commit manually when ready. - - HALT - User cancelled - - - - - Execute: git add . - Execute: git status - ✅ All changes staged - - - Analyze changes to determine commit type and scope: - - feat: New feature implementation - - fix: Bug fixes - - docs: Documentation updates - - refactor: Code restructuring - - test: Test additions/updates - - chore: Tooling, configs, dependencies - - Generate commit message in conventional commit format: - Format: - [type](optional scope): Brief summary (max 72 chars) - - - Key change 1 - - Key change 2 - - Key change 3 - - - Base message on: - - Story title and key - - Files changed - - Acceptance criteria met - - Recent commit style - - - 📝 **Generated Commit Message:** - - ``` - {{generated_commit_message}} - ``` - - - Use this commit message? [yes/edit/cancel]: - - - Enter your commit message: - Use user-provided message as {{commit_message}} - - - - ❌ Push-all cancelled. Changes remain staged. - - Run: git reset to unstage - - HALT - - - - Set {{commit_message}} = {{generated_commit_message}} - - - - Execute git commit with message: - git commit -m "$(cat <<'EOF' - {{commit_message}} - EOF - )" - - - - ❌ Commit failed - - Error: {{commit_error}} - - Common issues: - - Pre-commit hooks failing - - Missing git config (user.name/email) - - Locked files - - Fix the issue and try again. - - HALT - Fix errors before proceeding - - - ✅ Commit created: {{commit_hash}} - - - Execute: git push - - - ⚠️ Push rejected - remote has changes - - Attempting: git pull --rebase && git push - - Execute: git pull --rebase - Execute: git push - - - - ℹ️ No upstream branch set - - Executing: git push -u origin {{current_branch}} - - Execute: git push -u origin {{current_branch}} - - - - ❌ Push failed - - Error: {{push_error}} - - Your changes are committed locally but not pushed. - You can push manually later with: git push - - HALT - Manual push required - - - - ✅ **Successfully Pushed to Remote!** - - **Commit:** {{commit_hash}} - {{commit_subject}} - **Branch:** {{current_branch}} → origin/{{current_branch}} - **Files changed:** {{file_count}} (+{{insertions}}, -{{deletions}}) - - **Story work is now on remote and ready for team review.** - - - Execute: git log -1 --oneline --decorate - - Final commit: {{git_log_output}} - - - - diff --git a/src/modules/bmm/workflows/4-implementation/autonomous-epic/instructions.xml b/src/modules/bmm/workflows/4-implementation/autonomous-epic/instructions.xml index 790d8cac..6bf85a7a 100644 --- a/src/modules/bmm/workflows/4-implementation/autonomous-epic/instructions.xml +++ b/src/modules/bmm/workflows/4-implementation/autonomous-epic/instructions.xml @@ -3,15 +3,15 @@ You MUST have already loaded and processed: {installed_path}/workflow.yaml Communicate all responses in {communication_language} 🤖 AUTONOMOUS EPIC PROCESSING - Full automation of epic completion! - This workflow creates and develops ALL stories in an epic with minimal human intervention + This workflow orchestrates create-story and super-dev-story for each story in an epic - + 🤖 **Autonomous Epic Processing** This workflow will automatically: - 1. Create all stories in the epic (just-in-time planning) - 2. Develop each story with comprehensive validation - 3. Commit changes after each story + 1. Create each story just-in-time (using create-story) + 2. Develop each story (using super-dev-story or dev-story) + 3. Commit and push after each story (integrated in super-dev) 4. Generate epic completion report **Time Estimate:** Varies by epic size @@ -20,22 +20,17 @@ - Large epic (11+ stories): 12-24 hours **Token Usage:** ~100K-150K per story - - Uses super-dev-story by default (highest quality) - - Auto-accepts gap analysis (minimal prompts) - - --- - + Use provided epic number - Enter epic number to process (e.g., "2", "epic-3"), or [q] to quit: + Enter epic number to process (e.g., "2" or "epic-3"), or [q] to quit: - Parse epic number from input (handle "2", "epic-2", "Epic 2" formats) - Set {{epic_num}} to parsed number + Parse epic number from input @@ -47,37 +42,8 @@ Load {{sprint_status}} file - Find epic-{{epic_num}} entry in development_status - - - ❌ Epic {{epic_num}} not found in sprint-status.yaml - - Available epics: - {{list_available_epics}} - - Run sprint-planning to initialize sprint tracking. - - HALT - - - Get epic status from sprint-status - - - ✅ Epic {{epic_num}} is already complete! - - All stories marked done. Nothing to process. - - HALT - - - Count stories in epic (pattern: {{epic_num}}-*) - Count stories by status: - - backlog: Not yet created - - ready-for-dev: Created but not developed - - in-progress: Partially developed - - review: Developed, pending review - - done: Fully complete - + Find epic-{{epic_num}} entry + Count stories by status (backlog, ready-for-dev, in-progress, review, done) 📊 **Epic {{epic_num}} Status** @@ -86,294 +52,145 @@ - Backlog: {{backlog_count}} (will create + develop) - Ready-for-dev: {{ready_count}} (will develop) - In-progress: {{inprogress_count}} (will resume) - - Review: {{review_count}} (will skip - needs human review) - - Done: {{done_count}} (will skip - already complete) + - Review/Done: {{done_count}} (will skip) - **Work Remaining:** {{backlog_count + ready_count + inprogress_count}} stories + **Work Remaining:** {{work_count}} stories **Estimated Time:** {{estimated_hours}} hours **Estimated Tokens:** ~{{estimated_tokens}}K - - **Proceed with autonomous processing?** - This will: - - Process {{work_count}} stories automatically - - Use {{dev_workflow}} for development (super-dev-story or dev-story) - - Create git commits after each story - - Take approximately {{estimated_hours}} hours - - Use approximately {{estimated_tokens}}K tokens - - Options: - [Y] Yes - Start autonomous processing with default settings - [C] Custom - Let me configure settings first - [n] No - Cancel autonomous processing + [Y] Yes - Use super-dev-story (comprehensive validation) + [D] Dev-story - Faster, less validation + [n] No - Cancel - - Use default autonomous_settings from workflow.yaml - ✅ Starting autonomous epic processing with defaults... - + + Set {{dev_workflow}} = "super-dev-story" - - Use super-dev-story (comprehensive validation) or dev-story (faster)? [super/dev]: - Store user choice as {{dev_workflow}} - - Auto-accept gap analysis refinements? [Y/n]: - Store user choice as {{auto_accept_gap}} - - Create git commits after each story? [Y/n]: - Store user choice as {{create_commits}} - - Halt on first error or continue? [halt/continue]: - Store user choice as {{error_handling}} - - ✅ Custom settings configured. Starting autonomous processing... - + + Set {{dev_workflow}} = "dev-story" - - ❌ Autonomous epic processing cancelled. + + ❌ Cancelled HALT - - - - - Check current git branch - Create new branch: {{git_branch_prefix}}{{epic_num}} - 📝 Created git branch: {{git_branch_prefix}}{{epic_num}} - + + Get current branch name + Create new branch: auto-epic-{{epic_num}} + 📝 Created branch: auto-epic-{{epic_num}} - - Create progress file: {{progress_file}} - Write initial progress state: - epic_num: {{epic_num}} - started: {{date}} - total_stories: {{total_story_count}} - completed_stories: [] - failed_stories: [] - current_story: null - status: running + Initialize progress tracking file: + - epic_num + - started timestamp + - total_stories + - completed_stories: [] + - current_story: null + - status: running - - 🚀 **Autonomous Epic Processing Started** - - Epic: {{epic_num}} - Branch: {{git_branch_name}} - Progress tracking: {{progress_file}} - - Processing {{work_count}} stories... - - - 🔄 STORY PROCESSING LOOP - Just-in-time planning + development + + 🔄 STORY LOOP - Create and develop each story - Load {{sprint_status}} file - Find all stories in epic {{epic_num}} (pattern: {{epic_num}}-*) - Sort stories by story number (ascending order) - Filter to stories needing work (backlog, ready-for-dev, in-progress statuses) - - Initialize {{story_counter}} = 0 - Initialize {{success_count}} = 0 - Initialize {{failure_count}} = 0 + Find all stories in epic {{epic_num}} needing work + Sort by story number (ascending) + Initialize counters: success=0, failure=0 - Set {{current_story}} = current story from loop - Increment {{story_counter}} - Update progress file with current_story + Set {{current_story}} - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - Story {{story_counter}}/{{work_count}}: {{current_story.key}} - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - Status: {{current_story.status}} - Started: {{current_time}} + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + Story {{counter}}/{{work_count}}: {{current_story.key}} + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - - 📝 Creating story {{current_story.key}}... + + 📝 Creating story... - Run create-story workflow for this story - Wait for story file to be created - ✅ Story created: {{story_file}} + + Create story just-in-time + + + ✅ Story created - ❌ Failed to create story {{current_story.key}} - - Error: {{error_message}} - - - - Update progress file with failure - 🛑 Halting due to error (halt_on_error=true) - HALT - - - - Add to {{failed_stories}} list - Increment {{failure_count}} - ⏭️ Skipping to next story... - Next story in loop - + ❌ Failed to create story: {{error}} + Add to failed_stories, continue to next + - 💻 Developing story {{current_story.key}} using {{dev_workflow}}... + 💻 Developing with {{dev_workflow}}... - Run super-dev-story workflow with auto-accept mode enabled + + + Includes: dev + post-gap + review + push-all + - Run dev-story workflow with auto-accept mode enabled + + + + + + + Commit and push story changes + - Wait for story to be marked "review" - - ✅ Story {{current_story.key}} completed - - Status: review - Tasks completed: {{task_count}} - Files changed: {{file_count}} - Time: {{elapsed_time}} - - - - 📝 Running push-all to commit and push story changes... - - - Run push-all workflow with auto-accept mode: - - Safety checks run automatically - - Generate commit message based on story - - Commit with message: "feat(epic-{{epic_num}}): complete story {{current_story.key}} - {{story_title}}" - - Push to remote automatically - - ✅ Pushed to remote: {{commit_hash}} - - - - ⚠️ Push-all failed for story {{current_story.key}} - - Error: {{push_error}} - - Story is complete but not pushed to remote yet. - You can push manually later. - - - - 🛑 Halting due to push error (halt_on_error=true) - Update progress file with failure - HALT - - - Note: Story complete locally, push failed - continuing... - - - Increment {{success_count}} - Add to progress file completed_stories list - Update progress file with success - + ✅ Story complete and pushed + Increment success_count + Update progress file - ❌ Failed to develop story {{current_story.key}} - - Error: {{error_message}} - Attempt: {{retry_count}}/{{max_retry_per_story}} - - - - 🔄 Retrying story {{current_story.key}}... - Increment {{retry_count}} - Retry this story - - - - ⚠️ Max retries reached for story {{current_story.key}} - - - Update progress file with failure and halt - 🛑 Halting due to repeated errors (halt_on_error=true) - HALT - - - - Add to {{failed_stories}} list - Increment {{failure_count}} - ⏭️ Skipping to next story... - Next story in loop - - + ❌ Story failed: {{error}} + Add to failed_stories, continue + Increment failure_count - - - Progress: {{success_count}} ✅ | {{failure_count}} ❌ | {{remaining_count}} pending - - + Progress: {{success_count}} ✅ | {{failure_count}} ❌ | {{remaining}} pending - Update progress file status: complete - - 📊 EPIC COMPLETE - Generate completion report - - Load all completed story files from this epic - Aggregate statistics: - - Total files created/modified - - Total test coverage - - Total code review issues found and fixed - - Total development time - - Success rate - - - Generate epic completion report: {{story_dir}}/epic-{{epic_num}}-completion-report.md - + - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ - 🎉 EPIC {{epic_num}} AUTONOMOUS PROCESSING COMPLETE! - ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ + 🎉 EPIC {{epic_num}} COMPLETE! + ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ **Results:** - ✅ Stories completed: {{success_count}}/{{total_story_count}} - {{if_failures}} - ❌ Stories failed: {{failure_count}} - {{list_failed_stories_with_reasons}} + ✅ Stories completed: {{success_count}}/{{total_count}} + {{if_failures}}❌ Stories failed: {{failure_count}}{{endif}} + + **Branch:** auto-epic-{{epic_num}} + **All changes pushed to remote** + + {{if_all_success}} + **Epic {{epic_num}} marked complete in sprint-status.yaml** {{endif}} - **Statistics:** - - Total development time: {{total_time}} - - Files created/modified: {{total_files}} - - Test coverage achieved: {{avg_coverage}}% - - Code review issues found: {{total_issues}} - - Code review issues fixed: {{total_fixes}} - - **Git Branch:** {{git_branch_name}} - **Commits:** {{commit_count}} - - **Completion Report:** {{report_file}} - - --- - **Next Steps:** - 1. Review the completion report - 2. Manually review/fix any failed stories - 3. Run human code review on the branch - 4. Merge {{git_branch_name}} when approved + 1. Review the work on branch auto-epic-{{epic_num}} + 2. Run human code review + 3. Merge when approved {{if_failures}} **Failed Stories Need Attention:** @@ -381,61 +198,11 @@ {{endif}} - - - Load {{sprint_status}} file - Update epic-{{epic_num}} status to "done" - ✅ Epic {{epic_num}} marked complete in sprint-status.yaml + + Update sprint-status: epic-{{epic_num}} = "done" - - ℹ️ Epic {{epic_num}} partially complete - some stories failed. - Epic status remains "in-progress" until failed stories resolved. - - - - - - 📝 All changes committed to branch: {{git_branch_name}} - - To merge: - git checkout main - git merge {{git_branch_name}} - - Or create PR: - gh pr create --base main --head {{git_branch_name}} - - - - - - Remove progress file (no longer needed) - - Would you like explanations about: - - How autonomous processing works - - What was implemented in this epic - - Why any stories failed - - How to review and merge the work - - Anything else? - - [Enter topic or 'n' to skip] - - - - Provide clear explanations about requested topics - Reference specific stories, code, or decisions - - - 💡 **Tips for Future Autonomous Processing:** - - - Use super-dev-story for critical epics (higher quality, more tokens) - - Use dev-story for experimental epics (faster, fewer tokens) - - Review completion report for patterns and improvements - - Failed stories often indicate unclear requirements - - Monitor token usage and adjust epic size accordingly - - **Epic {{epic_num}} processing complete, {user_name}!** - + Remove progress file diff --git a/src/modules/bmm/workflows/4-implementation/super-dev-story/instructions.xml b/src/modules/bmm/workflows/4-implementation/super-dev-story/instructions.xml index 4d5644c9..d777ad93 100644 --- a/src/modules/bmm/workflows/4-implementation/super-dev-story/instructions.xml +++ b/src/modules/bmm/workflows/4-implementation/super-dev-story/instructions.xml @@ -4,43 +4,60 @@ Communicate all responses in {communication_language} and language MUST be tailored to {user_skill_level} Generate all documents in {document_output_language} 🚀 SUPER-DEV MODE: Enhanced quality workflow with post-implementation validation and automated code review - This workflow ensures stories are TRULY complete through multi-stage validation before marking done - ⚙️ EXECUTION FLOW: First execute ALL dev-story steps (1-8), then continue with super-dev enhancements (9.5-9.6) + This workflow orchestrates existing workflows with additional validation steps - + - 🎯 EXECUTE DEV-STORY STEPS 1-8 FIRST - Follow all instructions in: {project-root}/_bmad/bmm/workflows/4-implementation/dev-story/instructions.xml - Complete Steps 1 through 8 exactly as specified in dev-story workflow - After Step 8 completes (all tasks checked), return here and continue with Step 9.5 below + + 🎯 RUN DEV-STORY - Complete all standard development steps + This includes: story loading, pre-dev gap analysis, development, testing, and task completion - ⚙️ Super-dev-story includes ALL standard dev-story steps (1-8): + 🚀 **Super-Dev-Story: Enhanced Quality Workflow** - **Standard Development Flow:** - - Step 1: Find and load story (sprint-status or user-provided path) - - Step 1.5: ✅ PRE-DEV GAP ANALYSIS - Validate tasks against codebase - - Step 2: Load project context and story information - - Step 3: Detect review continuation (if resuming after code-review) - - Step 4: Mark story in-progress in sprint-status - - Step 5: Implement task following red-green-refactor cycle (TDD) - - Step 6: Author comprehensive tests (unit, integration, e2e) - - Step 7: Run validations and tests (regression suite) - - Step 8: Validate and mark task complete (strict gates) + Running standard dev-story workflow (Steps 1-8)... - After completing Steps 1-8, super-dev mode adds ADDITIONAL quality validation below. + This includes: + ✅ Story loading and validation + ✅ Pre-dev gap analysis + ✅ TDD implementation cycle + ✅ Comprehensive testing + ✅ Task completion validation - **For complete details of Steps 1-8, see:** {project-root}/_bmad/bmm/workflows/4-implementation/dev-story/instructions.xml - + After dev-story completes, super-dev will add: + ✅ Post-dev gap analysis + ✅ Automated code review + ✅ Auto push-all + + + + + Pass through any user-provided story file path + + + + ✅ Dev-story complete - all tasks implemented and tested + + Proceeding to super-dev enhancements... + + + + + ❌ Dev-story did not complete successfully + + Cannot proceed with super-dev enhancements. + Fix issues and retry. + + HALT - dev-story must complete first + + - + - - - + 🔍 POST-DEV VALIDATION - Verify all work actually completed! This catches incomplete implementations that were prematurely marked done @@ -51,8 +68,8 @@ - Re-read story requirements and acceptance criteria - Extract all tasks and subtasks that are marked [x] complete + Re-read story file to get requirements and tasks + Extract all tasks marked [x] complete For each completed task, identify what should exist in codebase @@ -77,52 +94,29 @@ - Note partial implementations marked as complete - ⚠️ Quality Issues: - - Implementations that exist but don't meet requirements - - Tests that exist but have poor coverage - - Code that works but violates architecture patterns - - - + ⚠️ **Post-Dev Gaps Detected!** - **False Positives (marked done but not complete):** + **Tasks marked complete but implementation incomplete:** {{list_false_positives_with_details}} - **Quality Issues:** - {{list_quality_issues_with_details}} - - **Proposed Actions:** - {{list_tasks_to_add_for_missing_work}} - - --- - These issues must be addressed before story can be marked complete. Uncheck false positive tasks in story file - Add new tasks for missing work to Tasks/Subtasks section - Add note to Dev Agent Record: "Post-dev gap analysis found incomplete work - continuing implementation" + Add new tasks for missing work Update Gap Analysis section with post-dev findings - Set {{fix_iteration_count}} = {{fix_iteration_count}} + 1 - - 🛑 **Maximum Fix Iterations Reached** + 🔄 Re-invoking dev-story to complete missing work... - Attempted {{fix_iteration_count}} fix cycles. - Manual intervention required. + + + Resume with added tasks for missing work + - Issues remaining: - {{list_remaining_issues}} - - Add to Dev Agent Record: "HALTED - exceeded max fix iterations, manual review needed" - HALT - require user intervention - - - 🔄 Adding missing work to task list and continuing implementation... - Continue implementation with added tasks + ✅ Missing work completed. Proceeding to code review... @@ -132,13 +126,15 @@ Proceeding to code review... Update Gap Analysis section with post-dev verification results - Continue to Step 9.6 - + + + + + 👀 AUTO CODE REVIEW - Independent quality validation - Fresh perspective catches issues the dev agent might miss 🔍 **Running Automated Code Review** @@ -146,107 +142,56 @@ Analyzing implementation for issues... - - Extract File List from Dev Agent Record - Identify all files created or modified during implementation + + + Run code review on completed story + - - Perform comprehensive code review checking: - - **Correctness:** Logic errors, edge cases, error handling - - **Architecture:** Compliance with patterns and standards - - **Security:** Vulnerabilities, input validation, authentication - - **Performance:** Inefficiencies, N+1 queries, memory leaks - - **Testing:** Test coverage, edge cases, test quality - - **Code Quality:** Readability, maintainability, documentation + Parse code review results from story file "Code Review" section + Extract issues by severity (Critical, High, Medium, Low) + Count total issues found - - Categorize all findings by severity: - - CRITICAL: Security vulnerabilities, data loss, broken functionality - - HIGH: Logic errors, missing error handling, test gaps - - MEDIUM: Code quality issues, minor bugs, performance concerns - - LOW: Style issues, documentation improvements, minor refactoring + + 🚨 **Code Review Found Issues Requiring Fixes** - - - - 🚨 **Code Review Found Issues Requiring Fixes** + Issues found: {{total_issue_count}} + - Critical: {{critical_count}} + - High: {{high_count}} + - Medium: {{medium_count}} + - Low: {{low_count}} - **Critical Issues ({{critical_count}}):** - {{list_critical_issues}} - - **High Priority Issues ({{high_count}}):** - {{list_high_issues}} - - {{if_medium_or_low_exist}} - **Medium/Low Issues ({{med_low_count}}):** - {{list_medium_low_issues}} - {{endif}} - - --- - - **These issues must be fixed before story completion.** + Adding review findings to story tasks and re-running dev-story... - Add "Code Review Findings" section to story file - Add review findings as new tasks in Tasks/Subtasks with [AI-Review] prefix - Add to Dev Agent Record: "Code review found {{total_issue_count}} issues - continuing with fixes" - Set {{fix_iteration_count}} = {{fix_iteration_count}} + 1 + Add code review findings as tasks in story file - - 🛑 **Maximum Fix Iterations Reached** + + + Fix code review issues + - Code review found issues on iteration {{fix_iteration_count}}. - Manual review recommended. - - Issues found: - {{list_all_issues}} - - Add to Dev Agent Record: "HALTED - code review issues after max iterations, manual review needed" - HALT - require user intervention - - - 🔧 Adding review findings to task list and implementing fixes... - Implement fixes + ✅ Code review issues resolved. Proceeding to push... - - - ℹ️ **Code Review Found Minor Issues** + + ℹ️ **Code Review Found Minor Issues** - **Medium Issues ({{medium_count}}):** - {{list_medium_issues}} - - **Low Priority Issues ({{low_count}}):** - {{list_low_issues}} - - --- + - Medium: {{medium_count}} + - Low: {{low_count}} - Auto-fix these minor issues? - - Options: - [Y] Yes - Add to task list and fix now - [n] No - Document in story but don't fix (can address later) - [s] Skip - Ignore these findings - + Auto-fix these minor issues? [Y/n/skip]: - Add review findings as tasks with [AI-Review] prefix - Add to Dev Agent Record: "Addressing {{issue_count}} minor code review findings" - 🔧 Implementing minor fixes... - Implement fixes + Add review findings as tasks + + + - - Add "Code Review Findings" section documenting issues - Add to Dev Agent Record: "Code review found {{issue_count}} minor issues - documented for future work" - ℹ️ Issues documented in story. Proceeding to completion... - Continue to Step 9 - - - - ⚠️ Skipping minor issues. Proceeding to completion... - Continue to Step 9 + + Document issues in story file + ℹ️ Minor issues documented. Proceeding to push... @@ -254,81 +199,55 @@ ✅ **Code Review Passed** No issues found. Implementation meets quality standards. + Proceeding to push... - Add to Dev Agent Record: "Code review completed - no issues found" - Continue to Step 9 - - 🎯 FINAL VALIDATION - All quality gates must pass! + + + - Verify ALL tasks and subtasks are marked [x] (re-scan the story document now) - Run the full regression suite (do not skip) - Confirm File List includes every changed file - Execute enhanced definition-of-done validation + + 📝 PUSH-ALL - Stage, commit, and push with safety validation - - Validate super-dev quality gates: - - ✅ Pre-dev gap analysis completed and approved - - ✅ All tasks/subtasks marked complete with [x] - - ✅ Implementation satisfies every Acceptance Criterion - - ✅ All tests pass (no regressions, new tests successful) - - ✅ Post-dev gap analysis passed (no false positives) - - ✅ Code review completed (critical/high issues resolved) - - ✅ File List includes every new/modified/deleted file - - ✅ Dev Agent Record contains implementation notes - - ✅ Change Log includes summary of changes - + 📝 **Committing and Pushing Story Changes** - Update the story Status to: "review" + Running push-all workflow with safety checks... + - - - Load the FULL file: {sprint_status} - Find development_status key matching {{story_key}} - Verify current status is "in-progress" (expected previous state) - Update development_status[{{story_key}}] = "review" - Save file, preserving ALL comments and structure including STATUS DEFINITIONS - ✅ Story status updated to "review" in sprint-status.yaml + + Commit and push all story changes + + + + ✅ Changes pushed to remote successfully - - ℹ️ Story status updated to "review" in story file (no sprint tracking configured) - + + ⚠️ Push failed but story is complete locally - - HALT - Complete remaining tasks before marking ready for review - HALT - Fix regression issues before completing - HALT - Update File List with all changed files - HALT - Run post-dev validation before completing - HALT - Run code review before completing + You can push manually when ready. + + - - Prepare comprehensive summary in Dev Agent Record → Completion Notes + + + + 🎉 **SUPER-DEV STORY COMPLETE, {user_name}!** - **Story:** {{story_key}} - {{story_title}} - **Status:** review (ready for human review) - - --- - **Quality Gates Passed:** - ✅ Pre-dev gap analysis - Tasks validated before work started + ✅ Pre-dev gap analysis - Tasks validated before work ✅ Development - All tasks completed with TDD - ✅ Post-dev gap analysis - Implementation verified complete - ✅ Code review - {{total_issues_found}} issues found and resolved - ✅ All tests passing - No regressions - - **Implementation Summary:** - - Files changed: {{file_count}} - - Tests added: {{test_count}} - - Issues fixed: {{review_issues_fixed}} - - Fix iterations: {{fix_iteration_count}}/{{max_fix_iterations}} + ✅ Post-dev gap analysis - Implementation verified + ✅ Code review - Quality and security validated + ✅ Pushed to remote - Changes backed up **Story File:** {{story_file}} + **Status:** review (ready for human review) --- @@ -337,7 +256,7 @@ 2. 💻 Implementation completed per requirements 3. ✅ No false positive completions (all work verified) 4. 👀 Code quality and security validated - 5. 🧪 Comprehensive test coverage achieved + 5. 📝 Changes committed and pushed to remote **Next Steps:** - Review the completed story @@ -348,343 +267,17 @@ It should require minimal human review. - Based on {user_skill_level}, ask if user needs any explanations about: - - What was implemented and how it works - - Why certain technical decisions were made - - Gap analysis or code review findings - - Any patterns, libraries, or approaches used - + Based on {user_skill_level}, ask if user needs explanations about implementation, decisions, or findings - Provide clear, contextual explanations tailored to {user_skill_level} - Use examples and references to specific code when helpful + Provide clear, contextual explanations 💡 **Tip:** This story was developed with super-dev-story for enhanced quality. - For faster development (fewer validations), use standard `dev-story` workflow. - For maximum quality and fewer review cycles, continue using `super-dev-story`. + For faster development, use standard `dev-story` workflow. + For maximum quality, continue using `super-dev-story`. - - 📝 PUSH-ALL - Stage, commit, and push all changes with safety validation - ⚠️ Use with caution - commits ALL changes in repository - - 🔄 **Analyzing Repository Changes** - - Scanning for changes to commit and push... - - - - Run git commands in parallel: - - git status - Show modified/added/deleted/untracked files - - git diff --stat - Show change statistics - - git log -1 --oneline - Show recent commit for message style - - git branch --show-current - Confirm current branch - - Parse git status output to identify: - - Modified files - - Added files - - Deleted files - - Untracked files - - Total insertion/deletion counts - - - - 🔒 SAFETY VALIDATION - Check for secrets, large files, and unwanted artifacts - - Scan all changed files for dangerous patterns: - - **Secret Detection:** - Check for files matching secret patterns: - - .env*, *.key, *.pem, credentials.json, secrets.yaml - - id_rsa, *.p12, *.pfx, *.cer - - Any file containing: _API_KEY=, _SECRET=, _TOKEN= with real values - - - Validate API keys are placeholders only: - ✅ Acceptable: API_KEY=your-api-key-here, SECRET=placeholder, TOKEN=xxx, API_KEY=${'{YOUR_KEY}'} - ❌ BLOCK: OPENAI_API_KEY=sk-proj-*, AWS_SECRET_KEY=AKIA*, STRIPE_API_KEY=sk_live_* - - **File Size Check:** - Check for files >10MB without Git LFS - - **Build Artifacts:** - Check for unwanted directories/files: - - node_modules/, dist/, build/, __pycache__/, *.pyc, .venv/ - - .DS_Store, thumbs.db, *.swp, *.tmp - - - **Git State:** - Verify: - - .gitignore properly configured - - No merge conflicts - - Repository initialized - - - - - 🚨 **DANGER: Secrets Detected!** - - The following sensitive data was found: - {{list_detected_secrets}} - - ❌ **BLOCKED:** Cannot commit secrets to version control. - - **Actions Required:** - 1. Move secrets to .env file - 2. Add .env to .gitignore - 3. Use environment variables in code - 4. Remove secrets from tracked files - - Halting push-all workflow. - - HALT - Cannot proceed with secrets in changeset - - - - ⚠️ **Warning: Large Files Detected** - - Files >10MB found: - {{list_large_files}} - - **Recommendation:** Use Git LFS for large files - - Continue anyway? [y/n]: - - - Proceed with large files? [y/n]: - - - Halting push-all. Please set up Git LFS for large files. - HALT - - - - - ⚠️ **Warning: Build Artifacts Detected** - - Should not be committed: - {{list_build_artifacts}} - - **These should be in .gitignore** - - Continue anyway? [y/n]: - - - Proceed despite build artifacts? [y/n]: - - - Halting push-all. Update .gitignore to exclude build artifacts. - HALT - - - - - ⚠️ **Warning: Pushing to {{branch_name}}** - - You're on the main/master branch. Consider: - - Creating a feature branch - - Opening a PR for review - - Continue pushing to {{branch_name}}? [y/n]: - - - Push directly to {{branch_name}}? [y/n]: - - - Halting push-all. Create a feature branch instead. - HALT - - - - - - 📊 **Changes Summary** - - **Files:** - - Modified: {{modified_count}} - - Added: {{added_count}} - - Deleted: {{deleted_count}} - - Untracked: {{untracked_count}} - - **Changes:** - - Insertions: +{{insertion_count}} - - Deletions: -{{deletion_count}} - - **Safety Checks:** - {{if_all_safe}} - ✅ No secrets detected - ✅ No large files - ✅ No build artifacts - ✅ .gitignore configured - {{endif}} - - {{if_warnings}} - ⚠️ {{warning_list}} - {{endif}} - - **Git:** - - Branch: {{current_branch}} → origin/{{current_branch}} - - Last commit: {{last_commit}} - - --- - - **I will execute:** - 1. git add . - 2. git commit -m "[generated message]" - 3. git push - - - - **Proceed with commit and push?** - - Type 'yes' to proceed, 'no' to cancel, or 'review' to see detailed diff: - - - - Run: git diff --stat - Show detailed file changes - Still proceed with commit and push? [yes/no]: - - - - ❌ Push-all cancelled. Changes remain unstaged. - - You can commit manually when ready. - - HALT - User cancelled - - - - - Execute: git add . - Execute: git status - ✅ All changes staged - - - Analyze changes to determine commit type and scope: - - feat: New feature implementation - - fix: Bug fixes - - docs: Documentation updates - - refactor: Code restructuring - - test: Test additions/updates - - chore: Tooling, configs, dependencies - - Generate commit message in conventional commit format: - Format: - [type](optional scope): Brief summary (max 72 chars) - - - Key change 1 - - Key change 2 - - Key change 3 - - - Base message on: - - Story title and key - - Files changed - - Acceptance criteria met - - Recent commit style - - - 📝 **Generated Commit Message:** - - ``` - {{generated_commit_message}} - ``` - - - Use this commit message? [yes/edit/cancel]: - - - Enter your commit message: - Use user-provided message as {{commit_message}} - - - - ❌ Push-all cancelled. Changes remain staged. - - Run: git reset to unstage - - HALT - - - - Set {{commit_message}} = {{generated_commit_message}} - - - - Execute git commit with message: - git commit -m "$(cat <<'EOF' - {{commit_message}} - EOF - )" - - - - ❌ Commit failed - - Error: {{commit_error}} - - Common issues: - - Pre-commit hooks failing - - Missing git config (user.name/email) - - Locked files - - Fix the issue and try again. - - HALT - Fix errors before proceeding - - - ✅ Commit created: {{commit_hash}} - - - Execute: git push - - - ⚠️ Push rejected - remote has changes - - Attempting: git pull --rebase && git push - - Execute: git pull --rebase - Execute: git push - - - - ℹ️ No upstream branch set - - Executing: git push -u origin {{current_branch}} - - Execute: git push -u origin {{current_branch}} - - - - ❌ Push failed - - Error: {{push_error}} - - Your changes are committed locally but not pushed. - You can push manually later with: git push - - HALT - Manual push required - - - - ✅ **Successfully Pushed to Remote!** - - **Commit:** {{commit_hash}} - {{commit_subject}} - **Branch:** {{current_branch}} → origin/{{current_branch}} - **Files changed:** {{file_count}} (+{{insertions}}, -{{deletions}}) - - **Story work is now on remote and ready for team review.** - - - Execute: git log -1 --oneline --decorate - - Final commit: {{git_log_output}} - - - -