ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

fix: address Copilot review feedback for external agent code review 

- Rename misleading "CLAUDE CODE CLEANUP" comment to generic "SHELL CLEANUP"
- Remove unused external_prompt variable loading action
- Increase external agent timeout from 5 to 10 minutes for complex reviews
- Fix Review Method output to show actual method used instead of "OR"
- Restore web_bundle: false setting needed by web bundler
This commit is contained in:
Scott Jennings 2025-12-13 07:17:28 -06:00
parent a88bb43eba
commit 57f59b2e5c
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/modules/bmm/workflows/4-implementation/code-review/instructions.xml
View File

@ -5,7 +5,7 @@
<critical>Generate all documents in {document_output_language}</critical> <critical>Generate all documents in {document_output_language}</critical>
<!-- ================================================================ --> <!-- ================================================================ -->
<!-- CLAUDE CODE CLEANUP - MANDATORY KILL OF ALL BACKGROUND SHELLS --> <!-- SHELL CLEANUP - MANDATORY KILL OF ALL BACKGROUND SHELLS -->
<!-- ================================================================ --> <!-- ================================================================ -->
<!-- CRITICAL: Stale external agent processes cause context pollution. <!-- CRITICAL: Stale external agent processes cause context pollution.
You MUST kill ALL background shells BEFORE doing ANYTHING else. You MUST kill ALL background shells BEFORE doing ANYTHING else.
@ -203,19 +203,18 @@
<!-- External agent prompt is loaded from external-agent-prompt.md --> <!-- External agent prompt is loaded from external-agent-prompt.md -->
<set-var name="external_prompt_file" value="{installed_path}/external-agent-prompt.md" /> <set-var name="external_prompt_file" value="{installed_path}/external-agent-prompt.md" />
<action>Load {{external_prompt_file}} content into {{external_prompt}}</action>
<check if="{{external_agent_cmd}} == 'codex'"> <check if="{{external_agent_cmd}} == 'codex'">
<critical>CODEX: Use codex exec with read-only sandbox and full-auto</critical> <critical>CODEX: Use codex exec with read-only sandbox and full-auto</critical>
<invoke-bash cmd="codex exec --sandbox read-only --full-auto &quot;$(cat '{{external_prompt_file}}')&quot;" timeout="300000" /> <invoke-bash cmd="codex exec --sandbox read-only --full-auto &quot;$(cat '{{external_prompt_file}}')&quot;" timeout="600000" />
</check> </check>
<check if="{{external_agent_cmd}} == 'gemini'"> <check if="{{external_agent_cmd}} == 'gemini'">
<critical>GEMINI: Use gemini -p with prompt from file and --yolo</critical> <critical>GEMINI: Use gemini -p with prompt from file and --yolo</critical>
<invoke-bash cmd="gemini -p &quot;$(cat '{{external_prompt_file}}')&quot; --yolo" timeout="300000" /> <invoke-bash cmd="gemini -p &quot;$(cat '{{external_prompt_file}}')&quot; --yolo" timeout="600000" />
</check> </check>
<check if="{{external_agent_cmd}} == 'claude'"> <check if="{{external_agent_cmd}} == 'claude'">
<critical>CLAUDE: Use claude -p with prompt from file</critical> <critical>CLAUDE: Use claude -p with prompt from file</critical>
<invoke-bash cmd="claude -p &quot;$(cat '{{external_prompt_file}}')&quot; --dangerously-skip-permissions" timeout="300000" /> <invoke-bash cmd="claude -p &quot;$(cat '{{external_prompt_file}}')&quot; --dangerously-skip-permissions" timeout="600000" />
</check> </check>
<check if="{{bash_exit_code}} != 0 OR {{bash_stdout}} is empty"> <check if="{{bash_exit_code}} != 0 OR {{bash_stdout}} is empty">
@ -297,7 +296,7 @@
<output>**🔥 CODE REVIEW FINDINGS, {user_name}!** <output>**🔥 CODE REVIEW FINDINGS, {user_name}!**
**Story:** {{story_file}} **Story:** {{story_file}}
**Review Method:** {{external_agent_cmd}} OR built-in **Review Method:** {{#if external_agent_cmd}}{{external_agent_cmd}} CLI{{else}}built-in{{/if}}
**Git vs Story Discrepancies:** {{git_discrepancy_count}} found **Git vs Story Discrepancies:** {{git_discrepancy_count}} found
**Issues Found:** {{high_count}} High, {{medium_count}} Medium, {{low_count}} Low **Issues Found:** {{high_count}} High, {{medium_count}} Medium, {{low_count}} Low

1
src/modules/bmm/workflows/4-implementation/code-review/workflow.yaml
View File

@ -57,3 +57,4 @@ input_file_patterns:
load_strategy: "INDEX_GUIDED" load_strategy: "INDEX_GUIDED"
standalone: true standalone: true
web_bundle: false