This commit is contained in:
Wojciech Tyziniec 2025-11-26 14:49:43 -06:00 committed by GitHub
commit 4bfe7e7b39
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 13 deletions

View File

@ -1937,12 +1937,11 @@ If AgentVibes party mode is enabled, immediately trigger TTS with agent's voice:
const existingBmadFolderName = path.basename(bmadDir); const existingBmadFolderName = path.basename(bmadDir);
const newBmadFolderName = this.configCollector.collectedConfig.core?.bmad_folder || existingBmadFolderName; const newBmadFolderName = this.configCollector.collectedConfig.core?.bmad_folder || existingBmadFolderName;
if (existingBmadFolderName === newBmadFolderName) { // Stop spinner before calling install() since install() manages its own spinner
// Normal quick update - start the spinner spinner.stop();
spinner.start('Updating BMAD installation...');
} else { // Notify user if folder name will change
// Folder name has changed - stop spinner and let install() handle it if (existingBmadFolderName !== newBmadFolderName) {
spinner.stop();
console.log(chalk.yellow(`\n⚠️ Folder name will change: ${existingBmadFolderName}${newBmadFolderName}`)); console.log(chalk.yellow(`\n⚠️ Folder name will change: ${existingBmadFolderName}${newBmadFolderName}`));
console.log(chalk.yellow('The installer will handle the folder migration.\n')); console.log(chalk.yellow('The installer will handle the folder migration.\n'));
} }
@ -1961,14 +1960,11 @@ If AgentVibes party mode is enabled, immediately trigger TTS with agent's voice:
_savedIdeConfigs: savedIdeConfigs, // Pass saved IDE configs to installer _savedIdeConfigs: savedIdeConfigs, // Pass saved IDE configs to installer
}; };
// Call the standard install method // Call the standard install method (it will manage its own spinner)
const result = await this.install(installConfig); const result = await this.install(installConfig);
// Only succeed the spinner if it's still spinning // Note: Completion message is shown by the caller in commands/install.js
// (install method might have stopped it if folder name changed) // to avoid duplication and provide more detailed success information
if (spinner.isSpinning) {
spinner.succeed('Quick update complete!');
}
return { return {
success: true, success: true,
@ -1979,7 +1975,12 @@ If AgentVibes party mode is enabled, immediately trigger TTS with agent's voice:
ides: configuredIdes, ides: configuredIdes,
}; };
} catch (error) { } catch (error) {
spinner.fail('Quick update failed'); // Ensure spinner is stopped
if (spinner.isSpinning) {
spinner.stop();
}
// Provide operation context before detailed error from caller
console.error(chalk.red('✗ Quick update failed'));
throw error; throw error;
} }
} }