From 4ba6e193037a87a9c4c5a4db32a862de0d684db7 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 5 Jan 2026 06:29:52 -0800 Subject: [PATCH] refactor(code-review): rename SUCCESS METRICS to COMPLETION CHECKLIST MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Correct terminology: - "Metrics" implies quantitative measurement - These are actually pass/fail criteria for step completion - Section is self-validation checklist, not measurement data Reframe as checkpoint before proceeding to next step: - Add "Before proceeding to the next step, verify ALL of the following:" - Change "If any metric" to "If any item" - Explicit instruction: "Do NOT proceed to the next step" if checklist fails 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 --- .../code-review/steps/step-01-load-story.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md index bac25ea1..b5bcd2cb 100644 --- a/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md +++ b/src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md @@ -105,7 +105,9 @@ Set `git_discrepancies` with categories: --- -## SUCCESS METRICS +## COMPLETION CHECKLIST + +Before proceeding to the next step, verify ALL of the following: - `story_path` identified and loaded - `story_key` extracted @@ -115,7 +117,5 @@ Set `git_discrepancies` with categories: - `git_discrepancies` calculated - Explicit NEXT directive provided -## FAILURE MODES - -Failure to meet any SUCCESS METRIC constitutes workflow failure. +**If any item is not met:** Report to the user immediately and HALT the workflow. Do NOT proceed to the next step.