From 48c2324b2851a230944bb36081fd976c51b41d1e Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Thu, 2 Apr 2026 07:13:35 -0700 Subject: [PATCH] chore: remove QA agent (Quinn) and migrate capability to Developer agent (#2179) Delete the Quinn (bmad-agent-qa) agent wrapper and add QA test-generation capability to Amelia (bmad-agent-dev). Update agent tables, testing docs (EN/ZH-CN/FR), marketplace.json, party-mode, and checklist references. Co-authored-by: Claude Opus 4.6 (1M context) --- .claude-plugin/marketplace.json | 1 - docs/fr/reference/testing.md | 6 +- docs/reference/agents.md | 5 +- docs/reference/testing.md | 34 +++++------ docs/zh-cn/reference/agents.md | 5 +- docs/zh-cn/reference/testing.md | 28 ++++----- .../4-implementation/bmad-agent-dev/SKILL.md | 1 + .../4-implementation/bmad-agent-qa/SKILL.md | 61 ------------------- .../bmad-agent-qa/bmad-skill-manifest.yaml | 11 ---- .../bmad-qa-generate-e2e-tests/checklist.md | 2 +- src/core-skills/bmad-party-mode/SKILL.md | 2 +- 11 files changed, 41 insertions(+), 115 deletions(-) delete mode 100644 src/bmm-skills/4-implementation/bmad-agent-qa/SKILL.md delete mode 100644 src/bmm-skills/4-implementation/bmad-agent-qa/bmad-skill-manifest.yaml diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index f8921ac14..ad8e9e528 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -60,7 +60,6 @@ "./src/bmm-skills/3-solutioning/bmad-generate-project-context", "./src/bmm-skills/4-implementation/bmad-agent-dev", "./src/bmm-skills/4-implementation/bmad-agent-sm", - "./src/bmm-skills/4-implementation/bmad-agent-qa", "./src/bmm-skills/4-implementation/bmad-dev-story", "./src/bmm-skills/4-implementation/bmad-quick-dev", "./src/bmm-skills/4-implementation/bmad-sprint-planning", diff --git a/docs/fr/reference/testing.md b/docs/fr/reference/testing.md index a7e487df4..effd4174e 100644 --- a/docs/fr/reference/testing.md +++ b/docs/fr/reference/testing.md @@ -24,9 +24,9 @@ La plupart des projets devraient commencer avec le workflow QA intégré. Si vou ## Workflow QA Intégré -Le workflow QA intégré est inclus dans le module BMM (suite Agile). Il génère rapidement des tests fonctionnels en utilisant le framework de test existant de votre projet — aucune configuration ni installation supplémentaire requise. +Le workflow QA intégré (`bmad-qa-generate-e2e-tests`) fait partie du module BMM (suite Agile), disponible via l'agent Developer. Il génère rapidement des tests fonctionnels en utilisant le framework de test existant de votre projet — aucune configuration ni installation supplémentaire requise. -**Déclencheur :** `QA` ou `bmad-qa-generate-e2e-tests` +**Déclencheur :** `QA` (via l'agent Developer) ou `bmad-qa-generate-e2e-tests` ### Ce que le Workflow QA Fait @@ -98,7 +98,7 @@ TEA supporte également la priorisation basée sur les risques P0-P3 et des int Le workflow Automate du QA intégré apparaît dans la Phase 4 (Implémentation) de la carte de workflow méthode BMad. Il est conçu pour s'exécuter **après qu'un epic complet soit terminé** — une fois que toutes les stories d'un epic ont été implémentées et revues. Une séquence typique : 1. Pour chaque story de l'epic : implémenter avec Dev Story (`DS`), puis valider avec Code Review (`CR`) -2. Après la fin de l'epic : générer les tests avec le workflow QA (`QA`) ou le workflow Automate de TEA +2. Après la fin de l'epic : générer les tests avec `QA` (via l'agent Developer) ou le workflow Automate de TEA 3. Lancer la rétrospective (`bmad-retrospective`) pour capturer les leçons apprises Le workflow QA travaille directement à partir du code source sans charger les documents de planification (PRD, architecture). Les workflows TEA peuvent s'intégrer avec les artefacts de planification en amont pour la traçabilité. diff --git a/docs/reference/agents.md b/docs/reference/agents.md index 52024fcea..404d14bdb 100644 --- a/docs/reference/agents.md +++ b/docs/reference/agents.md @@ -13,7 +13,7 @@ This page lists the default BMM (Agile suite) agents that install with BMad Meth - Each agent is available as a skill, generated by the installer. The skill ID (e.g., `bmad-dev`) is used to invoke the agent. - Triggers are the short menu codes (e.g., `CP`) and fuzzy matches shown in each agent menu. -- QA (Quinn) is the lightweight test automation agent in BMM. The full Test Architect (TEA) lives in its own module. +- QA test generation is handled by the `bmad-qa-generate-e2e-tests` workflow skill, available through the Developer agent. The full Test Architect (TEA) lives in its own module. | Agent | Skill ID | Triggers | Primary workflows | | --------------------------- | -------------------- | ---------------------------------- | --------------------------------------------------------------------------------------------------- | @@ -21,8 +21,7 @@ This page lists the default BMM (Agile suite) agents that install with BMad Meth | Product Manager (John) | `bmad-pm` | `CP`, `VP`, `EP`, `CE`, `IR`, `CC` | Create/Validate/Edit PRD, Create Epics and Stories, Implementation Readiness, Correct Course | | Architect (Winston) | `bmad-architect` | `CA`, `IR` | Create Architecture, Implementation Readiness | | Scrum Master (Bob) | `bmad-sm` | `SP`, `CS`, `ER`, `CC` | Sprint Planning, Create Story, Epic Retrospective, Correct Course | -| Developer (Amelia) | `bmad-dev` | `DS`, `QD`, `CR` | Dev Story, Quick Dev, Code Review | -| QA Engineer (Quinn) | `bmad-qa` | `QA` | Automate (generate tests for existing features) | +| Developer (Amelia) | `bmad-dev` | `DS`, `QD`, `QA`, `CR` | Dev Story, Quick Dev, QA Test Generation, Code Review | | UX Designer (Sally) | `bmad-ux-designer` | `CU` | Create UX Design | | Technical Writer (Paige) | `bmad-tech-writer` | `DP`, `WD`, `US`, `MG`, `VD`, `EC` | Document Project, Write Document, Update Standards, Mermaid Generate, Validate Doc, Explain Concept | diff --git a/docs/reference/testing.md b/docs/reference/testing.md index f7832c2e6..d605e4932 100644 --- a/docs/reference/testing.md +++ b/docs/reference/testing.md @@ -1,15 +1,15 @@ --- title: Testing Options -description: Comparing the built-in QA agent (Quinn) with the Test Architect (TEA) module for test automation. +description: Comparing the built-in QA workflow with the Test Architect (TEA) module for test automation. sidebar: order: 5 --- -BMad provides two testing paths: a built-in QA agent for fast test generation and an installable Test Architect module for enterprise-grade test strategy. +BMad provides two testing paths: a built-in QA workflow for fast test generation and an installable Test Architect module for enterprise-grade test strategy. ## Which Should You Use? -| Factor | Quinn (Built-in QA) | TEA Module | +| Factor | Built-in QA | TEA Module | | --- | --- | --- | | **Best for** | Small-medium projects, quick coverage | Large projects, regulated or complex domains | | **Setup** | Nothing to install -- included in BMM | Install separately via `npx bmad-method install` | @@ -18,19 +18,19 @@ BMad provides two testing paths: a built-in QA agent for fast test generation an | **Strategy** | Happy path + critical edge cases | Risk-based prioritization (P0-P3) | | **Workflow count** | 1 (Automate) | 9 (design, ATDD, automate, review, trace, and others) | -:::tip[Start with Quinn] -Most projects should start with Quinn. If you later need test strategy, quality gates, or requirements traceability, install TEA alongside it. +:::tip[Start with built-in QA] +Most projects should start with the built-in QA workflow. If you later need test strategy, quality gates, or requirements traceability, install TEA alongside it. ::: -## Built-in QA Agent (Quinn) +## Built-in QA Workflow -Quinn is the built-in QA agent in the BMM (Agile suite) module. It generates working tests quickly using your project's existing test framework -- no configuration or additional installation required. +The built-in QA workflow (`bmad-qa-generate-e2e-tests`) is part of the BMM (Agile suite) module, available through the Developer agent. It generates working tests quickly using your project's existing test framework -- no configuration or additional installation required. -**Trigger:** `QA` or `bmad-qa-generate-e2e-tests` +**Trigger:** `QA` (via the Developer agent) or `bmad-qa-generate-e2e-tests` -### What Quinn Does +### What It Does -Quinn runs a single workflow (Automate) that walks through five steps: +The QA workflow (Automate) walks through five steps: 1. **Detect test framework** -- scans `package.json` and existing test files for your framework (Jest, Vitest, Playwright, Cypress, or any standard runner). If none exists, analyzes the project stack and suggests one. 2. **Identify features** -- asks what to test or auto-discovers features in the codebase. @@ -38,7 +38,7 @@ Quinn runs a single workflow (Automate) that walks through five steps: 4. **Generate E2E tests** -- covers user workflows with semantic locators and visible-outcome assertions. 5. **Run and verify** -- executes the generated tests and fixes failures immediately. -Quinn produces a test summary saved to your project's implementation artifacts folder. +The workflow produces a test summary saved to your project's implementation artifacts folder. ### Test Patterns @@ -51,10 +51,10 @@ Generated tests follow a "simple and maintainable" philosophy: - **Clear descriptions** that read as feature documentation :::note[Scope] -Quinn generates tests only. For code review and story validation, use the Code Review workflow (`CR`) instead. +The QA workflow generates tests only. For code review and story validation, use the Code Review workflow (`CR`) instead. ::: -### When to Use Quinn +### When to Use Built-in QA - Quick test coverage for a new or existing feature - Beginner-friendly test automation without advanced setup @@ -91,16 +91,16 @@ TEA also supports P0-P3 risk-based prioritization and optional integrations with - Teams that need risk-based test prioritization across many features - Enterprise environments with formal quality gates before release - Complex domains where test strategy must be planned before tests are written -- Projects that have outgrown Quinn's single-workflow approach +- Projects that have outgrown the built-in QA's single-workflow approach ## How Testing Fits into Workflows -Quinn's Automate workflow appears in Phase 4 (Implementation) of the BMad Method workflow map. It is designed to run **after a full epic is complete** — once all stories in an epic have been implemented and code-reviewed. A typical sequence: +The QA Automate workflow appears in Phase 4 (Implementation) of the BMad Method workflow map. It is designed to run **after a full epic is complete** — once all stories in an epic have been implemented and code-reviewed. A typical sequence: 1. For each story in the epic: implement with Dev (`DS`), then validate with Code Review (`CR`) -2. After the epic is complete: generate tests with Quinn (`QA`) or TEA's Automate workflow +2. After the epic is complete: generate tests with `QA` (via the Developer agent) or TEA's Automate workflow 3. Run retrospective (`bmad-retrospective`) to capture lessons learned -Quinn works directly from source code without loading planning documents (PRD, architecture). TEA workflows can integrate with upstream planning artifacts for traceability. +The built-in QA workflow works directly from source code without loading planning documents (PRD, architecture). TEA workflows can integrate with upstream planning artifacts for traceability. For more on where testing fits in the overall process, see the [Workflow Map](./workflow-map.md). diff --git a/docs/zh-cn/reference/agents.md b/docs/zh-cn/reference/agents.md index 4d45044e9..acaa23e92 100644 --- a/docs/zh-cn/reference/agents.md +++ b/docs/zh-cn/reference/agents.md @@ -15,8 +15,7 @@ sidebar: | Product Manager (John) | `bmad-pm` | `CP`、`VP`、`EP`、`CE`、`IR`、`CC` | Create/Validate/Edit PRD、Create Epics and Stories、Implementation Readiness、Correct Course | | Architect (Winston) | `bmad-architect` | `CA`、`IR` | Create Architecture、Implementation Readiness | | Scrum Master (Bob) | `bmad-sm` | `SP`、`CS`、`ER`、`CC` | Sprint Planning、Create Story、Epic Retrospective、Correct Course | -| Developer (Amelia) | `bmad-dev` | `DS`、`QD`、`CR` | Dev Story、Quick Dev、Code Review | -| QA Engineer (Quinn) | `bmad-qa` | `QA` | Automate（为既有功能生成测试） | +| Developer (Amelia) | `bmad-dev` | `DS`、`QD`、`QA`、`CR` | Dev Story、Quick Dev、QA Test Generation、Code Review | | UX Designer (Sally) | `bmad-ux-designer` | `CU` | Create UX Design | | Technical Writer (Paige) | `bmad-tech-writer` | `DP`、`WD`、`US`、`MG`、`VD`、`EC` | Document Project、Write Document、Update Standards、Mermaid Generate、Validate Doc、Explain Concept | @@ -24,7 +23,7 @@ sidebar: - `Skill ID` 是直接调用该智能体的名称（例如 `bmad-dev`） - 触发器是进入智能体会话后可使用的菜单短码 -- QA（Quinn）是 BMM 内置轻量测试角色；完整 TEA 能力位于独立模块 +- QA 测试生成由 `bmad-qa-generate-e2e-tests` workflow skill 处理，通过 Developer 智能体调用；完整 TEA 能力位于独立模块 ## 触发器类型 diff --git a/docs/zh-cn/reference/testing.md b/docs/zh-cn/reference/testing.md index a3f035ffb..c5b7e3890 100644 --- a/docs/zh-cn/reference/testing.md +++ b/docs/zh-cn/reference/testing.md @@ -1,17 +1,17 @@ --- title: "测试选项" -description: 内置 QA（Quinn）与 TEA 模块对比：何时用哪个、各自边界是什么 +description: 内置 QA workflow 与 TEA 模块对比：何时用哪个、各自边界是什么 sidebar: order: 5 --- BMad 有两条测试路径： -- **Quinn（内置 QA）**：快速生成可运行测试 +- **内置 QA workflow**：快速生成可运行测试 - **TEA（可选模块）**：企业级测试策略与治理能力 -## 该选 Quinn 还是 TEA？ +## 该选内置 QA 还是 TEA？ -| 维度 | Quinn（内置 QA） | TEA 模块 | +| 维度 | 内置 QA | TEA 模块 | | --- | --- | --- | | 最适合 | 中小项目、快速补覆盖 | 大型项目、受监管或复杂业务 | | 安装成本 | 无需额外安装（BMM 内置） | 需通过安装器单独选择 | @@ -21,20 +21,20 @@ BMad 有两条测试路径： | workflow 数量 | 1（Automate） | 9（设计/自动化/审查/追溯等） | :::tip[默认建议] -大多数项目先用 Quinn。只有当你需要质量门控、合规追溯或系统化测试治理时，再引入 TEA。 +大多数项目先用内置 QA workflow。只有当你需要质量门控、合规追溯或系统化测试治理时，再引入 TEA。 ::: -## 内置 QA（Quinn） +## 内置 QA Workflow -Quinn 是 BMM 内置 agent，目标是用你现有测试栈快速落地测试，不要求额外配置。 +内置 QA workflow（`bmad-qa-generate-e2e-tests`）是 BMM 模块的一部分，通过 Developer 智能体调用。目标是用你现有测试栈快速落地测试，不要求额外配置。 **触发方式：** -- 菜单触发器：`QA` +- 菜单触发器：`QA`（通过 Developer 智能体） - skill：`bmad-qa-generate-e2e-tests` -### Quinn 会做什么 +### QA Workflow 会做什么 -Quinn 的 Automate 流程通常包含 5 步： +QA Automate 流程通常包含 5 步： 1. 检测现有测试框架（如 Jest、Vitest、Playwright、Cypress） 2. 确认待测功能（手动指定或自动发现） 3. 生成 API 测试（状态码、结构、主路径与错误分支） @@ -48,10 +48,10 @@ Quinn 的 Automate 流程通常包含 5 步： - 避免硬编码等待/休眠 :::note[范围边界] -Quinn 只负责“生成测试”。如需实现质量评审与故事验收，请配合代码审查 workflow（`CR` / `bmad-code-review`）。 +QA workflow 只负责”生成测试”。如需实现质量评审与故事验收，请配合代码审查 workflow（`CR` / `bmad-code-review`）。 ::: -### 何时用 Quinn +### 何时用内置 QA - 要快速补齐某个功能的测试覆盖 - 团队希望先获得可运行基线，再逐步增强 @@ -93,10 +93,10 @@ TEA 提供专家测试 agent（Murat）与 9 个结构化 workflow，覆盖策 按 BMad workflow-map，测试位于阶段 4（实施）： 1. epic 内逐个 story：开发（`DS` / `bmad-dev-story`）+ 代码审查（`CR` / `bmad-code-review`） -2. epic 完成后：用 Quinn 或 TEA 的 Automate 统一生成/补齐测试 +2. epic 完成后：用 `QA`（通过 Developer 智能体）或 TEA 的 Automate 统一生成/补齐测试 3. 最后执行复盘（`bmad-retrospective`） -Quinn 主要依据代码直接生成测试；TEA 可结合上游规划产物（如 PRD、architecture）实现更强追溯。 +内置 QA workflow 主要依据代码直接生成测试；TEA 可结合上游规划产物（如 PRD、architecture）实现更强追溯。 ## 相关参考 diff --git a/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md b/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md index a8096622f..c0d15c8f1 100644 --- a/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md @@ -43,6 +43,7 @@ When you are in this persona and the user calls a skill, this persona must carry |------|-------------|-------| | DS | Write the next or specified story's tests and code | bmad-dev-story | | QD | Unified quick flow — clarify intent, plan, implement, review, present | bmad-quick-dev | +| QA | Generate API and E2E tests for existing features | bmad-qa-generate-e2e-tests | | CR | Initiate a comprehensive code review across multiple quality facets | bmad-code-review | ## On Activation diff --git a/src/bmm-skills/4-implementation/bmad-agent-qa/SKILL.md b/src/bmm-skills/4-implementation/bmad-agent-qa/SKILL.md deleted file mode 100644 index 1a666fe50..000000000 --- a/src/bmm-skills/4-implementation/bmad-agent-qa/SKILL.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -name: bmad-agent-qa -description: QA engineer for test automation and coverage. Use when the user asks to talk to Quinn or requests the QA engineer. ---- - -# Quinn - -## Overview - -This skill provides a QA Engineer who generates tests quickly for existing features using standard test framework patterns. Act as Quinn — pragmatic, ship-it-and-iterate, focused on getting coverage fast without overthinking. - -## Identity - -Pragmatic test automation engineer focused on rapid test coverage. Specializes in generating tests quickly for existing features using standard test framework patterns. Simpler, more direct approach than the advanced Test Architect module. - -## Communication Style - -Practical and straightforward. Gets tests written fast without overthinking. "Ship it and iterate" mentality. Focuses on coverage first, optimization later. - -## Principles - -- Generate API and E2E tests for implemented code. -- Tests should pass on first run. - -## Critical Actions - -- Never skip running the generated tests to verify they pass -- Always use standard test framework APIs (no external utilities) -- Keep tests simple and maintainable -- Focus on realistic user scenarios - -**Need more advanced testing?** For comprehensive test strategy, risk-based planning, quality gates, and enterprise features, install the Test Architect (TEA) module. - -You must fully embody this persona so the user gets the best experience and help they need, therefore its important to remember you must not break character until the users dismisses this persona. - -When you are in this persona and the user calls a skill, this persona must carry through and remain active. - -## Capabilities - -| Code | Description | Skill | -|------|-------------|-------| -| QA | Generate API and E2E tests for existing features | bmad-qa-generate-e2e-tests | - -## On Activation - -1. Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve: - - Use `{user_name}` for greeting - - Use `{communication_language}` for all communications - - Use `{document_output_language}` for output documents - - Use `{planning_artifacts}` for output location and artifact scanning - - Use `{project_knowledge}` for additional context scanning - -2. **Continue with steps below:** - - **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it. - - **Greet and present capabilities** — Greet `{user_name}` warmly by name, always speaking in `{communication_language}` and applying your persona throughout the session. - -3. Remind the user they can invoke the `bmad-help` skill at any time for advice and then present the capabilities table from the Capabilities section above. - - **STOP and WAIT for user input** — Do NOT execute menu items automatically. Accept number, menu code, or fuzzy command match. - -**CRITICAL Handling:** When user responds with a code, line number or skill, invoke the corresponding skill by its exact registered name from the Capabilities table. DO NOT invent capabilities on the fly. diff --git a/src/bmm-skills/4-implementation/bmad-agent-qa/bmad-skill-manifest.yaml b/src/bmm-skills/4-implementation/bmad-agent-qa/bmad-skill-manifest.yaml deleted file mode 100644 index ebf5e98bb..000000000 --- a/src/bmm-skills/4-implementation/bmad-agent-qa/bmad-skill-manifest.yaml +++ /dev/null @@ -1,11 +0,0 @@ -type: agent -name: bmad-agent-qa -displayName: Quinn -title: QA Engineer -icon: "🧪" -capabilities: "test automation, API testing, E2E testing, coverage analysis" -role: QA Engineer -identity: "Pragmatic test automation engineer focused on rapid test coverage. Specializes in generating tests quickly for existing features using standard test framework patterns. Simpler, more direct approach than the advanced Test Architect module." -communicationStyle: "Practical and straightforward. Gets tests written fast without overthinking. 'Ship it and iterate' mentality. Focuses on coverage first, optimization later." -principles: "Generate API and E2E tests for implemented code. Tests should pass on first run." -module: bmm diff --git a/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/checklist.md b/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/checklist.md index 013bc6390..aa38ae890 100644 --- a/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/checklist.md +++ b/src/bmm-skills/4-implementation/bmad-qa-generate-e2e-tests/checklist.md @@ -1,4 +1,4 @@ -# Quinn Automate - Validation Checklist +# QA Automate - Validation Checklist ## Test Generation diff --git a/src/core-skills/bmad-party-mode/SKILL.md b/src/core-skills/bmad-party-mode/SKILL.md index b6b99ed5e..acdf2cb0c 100644 --- a/src/core-skills/bmad-party-mode/SKILL.md +++ b/src/core-skills/bmad-party-mode/SKILL.md @@ -102,7 +102,7 @@ The user drives what happens next. Common patterns: |---|---| | Continues the general discussion | Pick fresh agents, repeat the loop | | "Winston, what do you think about what Sally said?" | Spawn just Winston with Sally's response as context | -| "Bring in Quinn on this" | Spawn Quinn with a summary of the discussion so far | +| "Bring in Amelia on this" | Spawn Amelia with a summary of the discussion so far | | "I agree with John, let's go deeper on that" | Spawn John + 1-2 others to expand on John's point | | "What would Mary and Bob think about Winston's approach?" | Spawn Mary and Bob with Winston's response as context | | Asks a question directed at everyone | Back to step 1 with all agents |