From 4637cd286d82fbb9109cb4d97b6626a254e15e8c Mon Sep 17 00:00:00 2001 From: Brian Madison Date: Mon, 25 May 2026 09:53:47 -0500 Subject: [PATCH] fix(skills): extend activation gate to agent + new skills, refine placement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - bmad-product-brief / bmad-prd: pull activation_steps_append out of the numbered list so the sentinel reads as a paragraph break, not as the next list item. - bmad-investigate: move the sentinel above Step 7 (routing) — Step 7 is workflow routing, not activation; the gate must fire first. - bmad-agent-{analyst,tech-writer,pm,ux-designer,architect,dev}: add the same gate between Step 7 (append) and Step 8 (menu dispatch). Persona skills had the same short-circuit risk but no sentinel. - bmad-ux, bmad-spec: new skills introduced on main after this branch forked; apply the same gate so the pattern stays consistent. - removals.txt: register bmad-create-ux-design as renamed to bmad-ux. --- removals.txt | 3 +++ src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md | 2 ++ src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md | 2 ++ src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md | 3 ++- src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md | 2 ++ .../2-plan-workflows/bmad-agent-ux-designer/SKILL.md | 2 ++ src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md | 3 ++- src/bmm-skills/2-plan-workflows/bmad-ux/SKILL.md | 5 ++++- src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md | 2 ++ src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md | 2 ++ src/bmm-skills/4-implementation/bmad-investigate/SKILL.md | 4 ++-- src/core-skills/bmad-spec/SKILL.md | 5 ++++- 12 files changed, 29 insertions(+), 6 deletions(-) diff --git a/removals.txt b/removals.txt index a694583e6..968d98180 100644 --- a/removals.txt +++ b/removals.txt @@ -57,3 +57,6 @@ bmad-bmm-validate-prd # bmad-distillator: superseded by bmad-spec (universal intent distiller with # preservation-validated contract for downstream skills). bmad-distillator +# bmad-create-ux-design: renamed to bmad-ux (spine-based skill with separate +# DESIGN.md and EXPERIENCE.md outputs). +bmad-create-ux-design diff --git a/src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md b/src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md index 4653171df..c672058eb 100644 --- a/src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-agent-analyst/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey Mary, let's brainstorm"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md b/src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md index ff6430d93..1ff9016d2 100644 --- a/src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-agent-tech-writer/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey Paige, let's document this codebase"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md b/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md index d0e901e3a..ec06f0a3d 100644 --- a/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md +++ b/src/bmm-skills/1-analysis/bmad-product-brief/SKILL.md @@ -21,7 +21,8 @@ At the opening greeting, let the user know they can invoke `bmad-party-mode` for 4. `{workflow.external_sources}` is an org-configured registry of internal tools (knowledge bases, MCP tools); consult them alongside generic web research on the same triggers in `## Discovery`, org tools preferred when their directive matches. If a named tool is unavailable at runtime, fall back to standard behavior and note the gap when relevant. 5. Load `{project-root}/_bmad/bmm/config.yaml` (and `config.user.yaml` if present). Resolve `{user_name}`, `{communication_language}`, `{document_output_language}`, `{planning_artifacts}`, `{project_name}`, `{date}`. 6. Greet `{user_name}` in `{communication_language}` — and stay in `{communication_language}` for every turn for the entire run, not just the greeting. Detect intent (create / update / validate). If interactive and intent is unclear, ask; for headless behavior see `## Headless Mode`. -7. Execute each entry in `{workflow.activation_steps_append}` in order. + +Execute each entry in `{workflow.activation_steps_append}` in order. Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. diff --git a/src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md index 693072603..accf47d34 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-agent-pm/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey John, let's write the PRD"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/SKILL.md index cb261c3fb..f2ee265e8 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-agent-ux-designer/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey Sally, let's design the UX"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md index 2668a2819..db005fff7 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-prd/SKILL.md @@ -20,7 +20,8 @@ You are a master facilitator and coach helping the user create, edit, or validat 3. Load `{project-root}/_bmad/bmm/config.yaml` (+ `config.user.yaml` if present). Resolve `{user_name}`, `{communication_language}`, `{document_output_language}`, `{planning_artifacts}`, `{project_name}`, `{date}`. Missing keys → neutral defaults; never block. 4. If headless, follow `references/headless.md` for the whole run. Otherwise greet the user **by name** using `{user_name}` and **in their language** using `{communication_language}` — and stay in `{communication_language}` for every turn for the entire run, not just the greeting. In the greeting, let the user know that at any point they can invoke `bmad-party-mode` for multi-agent perspectives or `bmad-advanced-elicitation` for deeper exploration on a specific section. Then scan for misroute on the first message: if the signal points elsewhere (game → BMad GDS; express build → `bmad-quick-dev`; one-pager → `bmad-product-brief`; vet product idea → `bmad-prfaq`; agent skill or custom agent → `bmad-workflow-builder`), suggest they might want the other options before continuing. 5. Detect intent: **Create** (no PRD), **Update** (existing PRD), **Validate** (critique only). If ambiguous, ask. For Create intent, before binding a fresh workspace, scan `{workflow.prd_output_path}` for prior in-progress runs (folders matching `{workflow.run_folder_pattern}` whose `prd.md` frontmatter `status` is not `final`); if any exist, offer to resume rather than starting over. -6. Run `{workflow.activation_steps_append}`. + +Run `{workflow.activation_steps_append}`. Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. diff --git a/src/bmm-skills/2-plan-workflows/bmad-ux/SKILL.md b/src/bmm-skills/2-plan-workflows/bmad-ux/SKILL.md index 37dddbedb..295cdf75e 100644 --- a/src/bmm-skills/2-plan-workflows/bmad-ux/SKILL.md +++ b/src/bmm-skills/2-plan-workflows/bmad-ux/SKILL.md @@ -35,7 +35,10 @@ UX may lead, follow, or stand alone. Inherit `sources:` by reference; the spines 3. Load `{project-root}/_bmad/bmm/config.yaml` (+ `config.user.yaml` if present). Resolve `{user_name}`, `{communication_language}`, `{document_output_language}`, `{planning_artifacts}`, `{project_name}`, `{date}`. Missing keys → neutral defaults; never block. 4. If headless, follow `references/headless.md` for the whole run. Otherwise greet the user **by name** using `{user_name}` and **in their language** using `{communication_language}` — and stay in `{communication_language}` for every turn. In the greeting, let the user know `bmad-party-mode` and `bmad-advanced-elicitation` are always available. Then scan for misroute on the first message: PRD → `bmad-prd`; architecture → `bmad-create-architecture`; game UX → BMad GDS; agent/skill → `bmad-workflow-builder`; brief → `bmad-product-brief`. 5. Detect intent: **Create**, **Update**, **Validate**. For Create, before binding a fresh workspace, scan `{workflow.ux_output_path}` for prior in-progress runs (folders matching `{workflow.run_folder_pattern}` whose `DESIGN.md` frontmatter `status` is not `final`) and offer to resume rather than starting over. -6. Run `{workflow.activation_steps_append}`. + +Run `{workflow.activation_steps_append}`. + +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Modes diff --git a/src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md b/src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md index 1650aee09..b5807ba6e 100644 --- a/src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md +++ b/src/bmm-skills/3-solutioning/bmad-agent-architect/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey Winston, let's architect this"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md b/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md index 95a3b9594..22d158bfe 100644 --- a/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-agent-dev/SKILL.md @@ -63,6 +63,8 @@ Continue to prefix your messages with `{agent.icon}` throughout the session so t Execute each entry in `{agent.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 8: Dispatch or Present the Menu If the user's initial message already names an intent that clearly maps to a menu item (e.g. "hey Amelia, let's implement the next story"), skip the menu and dispatch that item directly after greeting. diff --git a/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md b/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md index 0f7e2419e..50e461917 100644 --- a/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-investigate/SKILL.md @@ -79,13 +79,13 @@ Greet `{user_name}` in `{communication_language}`. Run each entry in `{workflow.activation_steps_append}` in order. +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. + ### Step 7: Acknowledge and route Acknowledge the input as a reference (record paths and IDs; don't read raw content). Path to an existing case file → Outcome 0. Otherwise → Outcome 1. -Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. - ## Procedure ### Outcome 0: Existing case is loaded and surfaced diff --git a/src/core-skills/bmad-spec/SKILL.md b/src/core-skills/bmad-spec/SKILL.md index d3d437e15..97baefed3 100644 --- a/src/core-skills/bmad-spec/SKILL.md +++ b/src/core-skills/bmad-spec/SKILL.md @@ -22,7 +22,10 @@ Multiple skills may call to update the same spec over time. 2. Run `{workflow.activation_steps_prepend}`. Treat `{workflow.persistent_facts}` as foundational context (`file:` entries are loaded). 3. Load `{project-root}/_bmad/core/config.yaml` (and `config.user.yaml` if present), root level and `bmm` section. Resolve `{user_name}`, `{communication_language}`, `{document_output_language}`, `{planning_artifacts}`, `{project_name}`, `{date}`. 4. Detect mode. **Headless** when any of: no TTY, programmatic caller (another skill or non-interactive runner), or the first message pre-supplies all inputs and asks for an artifact path back. **Interactive** otherwise. In interactive mode, greet by `{user_name}` in `{communication_language}`, stay in that language, and mention that `bmad-party-mode` and `bmad-advanced-elicitation` are available for deeper exploration on any field. -5. Run `{workflow.activation_steps_append}`. + +Run `{workflow.activation_steps_append}`. + +Activation is complete. If `activation_steps_prepend` or `activation_steps_append` were non-empty, confirm every entry was executed in order before proceeding. Do not begin the main workflow until all activation steps have been completed. ## Workspace