From 407e1028d95c53de02de4c17cb22b534d7dcd77d Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Mon, 22 Jun 2026 15:26:30 -0700 Subject: [PATCH] fix: replace dev auto approval gate --- .../4-implementation/bmad-dev-auto/SKILL.md | 2 ++ .../4-implementation/bmad-dev-auto/step-02-plan.md | 11 +++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/SKILL.md b/src/bmm-skills/4-implementation/bmad-dev-auto/SKILL.md index 2491c21d9..0833126dd 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/SKILL.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/SKILL.md @@ -23,6 +23,8 @@ A specification is "Ready for Development" when: - **Logical**: Tasks ordered by dependency. - **Testable**: All ACs use Given/When/Then. - **Complete**: No placeholders or TBDs. +- **Sufficient**: No known requirement, acceptance, dependency, or implementation gaps remain unresolved. +- **Coherent**: No unresolved ambiguities or internal contradictions. ## Conventions diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md index 85c3baee8..4310befcc 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md @@ -7,8 +7,7 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md' ## RULES - YOU MUST ALWAYS SPEAK OUTPUT in your Agent communication style with the config `{communication_language}` -- No intermediate approvals. -- Never ask questions or wait for approval. +- No human interaction: do not ask questions or wait for approval in this step. ## INSTRUCTIONS @@ -19,13 +18,13 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md' 5. If intent gaps exist, do not fantasize and do not leave open questions. Set `{spec_file}` frontmatter status to `blocked`, append `## Auto Run Result` with `Status: blocked`, the unanswered questions, and evidence gathered, then terminate cleanly. 6. Warning check. If step-01 carried `multiple-goals`, add it to `{spec_file}` frontmatter `warnings`. If `{spec_file}` exceeds 1600 tokens, add `oversized` to frontmatter `warnings`. Continue either way. -### APPROVAL BLOCK +### READY-FOR-DEVELOPMENT GATE -Do not present a conversational checkpoint. +Re-read `{spec_file}` from disk and verify it meets the READY FOR DEVELOPMENT standard in `./SKILL.md`. -Re-read `{spec_file}` from disk. - **If the file is missing:** write a best-effort result artifact in `{implementation_artifacts}` with `Status: blocked`, `Blocking condition: planned spec file disappeared before implementation`, and terminate cleanly. -- **If the file exists:** compare the content to what you wrote. If it has changed since you wrote it, note the external edits in `## Auto Run Result`. Set `{spec_file}` frontmatter status to `blocked`, append `## Auto Run Result` with `Status: blocked`, `Blocking condition: missing spec approval/edit decision`, and terminate cleanly. +- **If the spec meets the standard:** set `{spec_file}` frontmatter status to `ready-for-dev`, then continue to step 3. +- **If the spec does not meet the standard:** repair it once, then re-read it from disk and verify again. If it still does not meet the standard, set `{spec_file}` frontmatter status to `blocked`, append `## Auto Run Result` with `Status: blocked`, the failing criteria, and evidence gathered, then terminate cleanly. ## NEXT