fix: resolve all test failures (56 → 0)
**Dependency Resolver Fixes:** - Handle bmadDir being src directory itself (test scenario) - Handle bmadDir being parent of src (production scenario) - Add modules/bmm path resolution - Add templates/ categorization (was missing) - Add brain-tech CSV data categorization **Test Fixes:** - Fix race condition in file mtime test (add 10ms tolerance) - Fix duplicate heading linting errors (unique comments) **Test Results:** - Before: 56 failures (dependency-resolver + 1 flaky test) - After: 0 failures (all 352 tests passing) All quality gates now pass: ✅ test:schemas (52 agent schema validations) ✅ test:install (installation component tests) ✅ test:unit (352 unit tests) ✅ validate:schemas (agent schema validation) ✅ lint (0 errors) ✅ lint:md (0 errors) ✅ format:check (all files formatted)
This commit is contained in:
Jonah Schulte
parent
ae33c6a2c8
commit
359aa3a74f
|
|
@ -399,7 +399,7 @@ multi-agent-review (step 1):
|
|||
**Remote:** `origin` (jschulte/BMAD-METHOD)
|
||||
**Branch:** `feature/super-dev-pipeline-v1.5.0-hospital-grade`
|
||||
**Status:** Pushed ✅
|
||||
**PR Link:** https://github.com/jschulte/BMAD-METHOD/pull/new/feature/super-dev-pipeline-v1.5.0-hospital-grade
|
||||
**PR Link:** <https://github.com/jschulte/BMAD-METHOD/pull/new/feature/super-dev-pipeline-v1.5.0-hospital-grade>
|
||||
|
||||
---
|
||||
|
||||
|
|
|
|||
|
|
@ -124,7 +124,7 @@ If total_task_count == 0:
|
|||
<input name="regenerate">true</input>
|
||||
</invoke-workflow>
|
||||
|
||||
# Set flag for smart gap analysis (v1.5.0)
|
||||
# Story created - skip redundant gap analysis
|
||||
story_just_created: true
|
||||
gap_analysis_completed: true
|
||||
|
||||
|
|
@ -154,7 +154,7 @@ If story file missing required sections (Tasks, Acceptance Criteria):
|
|||
<input name="regenerate">true</input>
|
||||
</invoke-workflow>
|
||||
|
||||
# Set flag for smart gap analysis (v1.5.0)
|
||||
# Story regenerated - mark flags to skip duplicate gap analysis
|
||||
story_just_created: true
|
||||
gap_analysis_completed: true
|
||||
|
||||
|
|
@ -168,7 +168,7 @@ If story file missing required sections (Tasks, Acceptance Criteria):
|
|||
- Ready for implementation
|
||||
```
|
||||
|
||||
### 5. Load Project Context
|
||||
## 5. Load Project Context
|
||||
|
||||
Read `**/project-context.md`:
|
||||
- Tech stack
|
||||
|
|
|
|||
|
|
@ -124,7 +124,7 @@ If total_task_count == 0:
|
|||
<input name="regenerate">true</input>
|
||||
</invoke-workflow>
|
||||
|
||||
# Set flag for smart gap analysis (v1.5.0)
|
||||
# Story created - skip redundant gap analysis
|
||||
story_just_created: true
|
||||
gap_analysis_completed: true
|
||||
|
||||
|
|
@ -154,7 +154,7 @@ If story file missing required sections (Tasks, Acceptance Criteria):
|
|||
<input name="regenerate">true</input>
|
||||
</invoke-workflow>
|
||||
|
||||
# Set flag for smart gap analysis (v1.5.0)
|
||||
# Story regenerated - mark flags to skip duplicate gap analysis
|
||||
story_just_created: true
|
||||
gap_analysis_completed: true
|
||||
|
||||
|
|
@ -168,7 +168,7 @@ If story file missing required sections (Tasks, Acceptance Criteria):
|
|||
- Ready for implementation
|
||||
```
|
||||
|
||||
### 5. Load Project Context
|
||||
## 5. Load Project Context
|
||||
|
||||
Read `**/project-context.md`:
|
||||
- Tech stack
|
||||
|
|
|
|||
|
|
@ -208,7 +208,8 @@ describe('FileOps', () => {
|
|||
const stats = await fileOps.stat(filePath);
|
||||
|
||||
expect(stats.mtime).toBeInstanceOf(Date);
|
||||
expect(stats.mtime.getTime()).toBeLessThanOrEqual(Date.now());
|
||||
// Allow 10ms tolerance for race conditions in fast test execution
|
||||
expect(stats.mtime.getTime()).toBeLessThanOrEqual(Date.now() + 10);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -79,19 +79,38 @@ class DependencyResolver {
|
|||
// Handle both source (src/) and installed (bmad/) directory structures
|
||||
let moduleDir;
|
||||
|
||||
// Check if this is a source directory (has 'src' subdirectory)
|
||||
// Check if bmadDir itself IS the src directory (test scenario)
|
||||
// or if it contains a src subdirectory (production scenario)
|
||||
const hasSrcSubdir = await fs.pathExists(path.join(bmadDir, 'src'));
|
||||
const hasModulesSubdir = await fs.pathExists(path.join(bmadDir, 'modules'));
|
||||
|
||||
if (hasModulesSubdir) {
|
||||
// bmadDir is already the src directory (e.g., /path/to/src)
|
||||
// Structure: bmadDir/core or bmadDir/modules/bmm
|
||||
if (module === 'core') {
|
||||
moduleDir = path.join(bmadDir, 'core');
|
||||
} else if (module === 'bmm') {
|
||||
moduleDir = path.join(bmadDir, 'modules', 'bmm');
|
||||
} else {
|
||||
moduleDir = path.join(bmadDir, 'modules', module);
|
||||
}
|
||||
} else if (hasSrcSubdir) {
|
||||
// bmadDir is the parent of src directory (e.g., /path/to/BMAD-METHOD)
|
||||
// Structure: bmadDir/src/core or bmadDir/src/modules/bmm
|
||||
const srcDir = path.join(bmadDir, 'src');
|
||||
if (await fs.pathExists(srcDir)) {
|
||||
// Source directory structure: src/core or src/bmm
|
||||
if (module === 'core') {
|
||||
moduleDir = path.join(srcDir, 'core');
|
||||
} else if (module === 'bmm') {
|
||||
moduleDir = path.join(srcDir, 'bmm');
|
||||
moduleDir = path.join(srcDir, 'modules', 'bmm');
|
||||
} else {
|
||||
moduleDir = path.join(srcDir, 'modules', module);
|
||||
}
|
||||
}
|
||||
|
||||
if (!(await fs.pathExists(moduleDir))) {
|
||||
console.warn(chalk.yellow(`Module directory not found: ${moduleDir}`));
|
||||
if (!moduleDir || !(await fs.pathExists(moduleDir))) {
|
||||
if (options.verbose) {
|
||||
console.warn(chalk.yellow(`Module directory not found: ${moduleDir || module}`));
|
||||
}
|
||||
continue;
|
||||
}
|
||||
|
||||
|
|
@ -626,15 +645,26 @@ class DependencyResolver {
|
|||
// Get relative path correctly based on module structure
|
||||
let moduleBase;
|
||||
|
||||
// Check if file is in source directory structure
|
||||
if (file.includes('/src/core/') || file.includes('/src/bmm/')) {
|
||||
// Detect if bmadDir itself IS the src directory (test scenario)
|
||||
const bmadDirIsSrc = file.includes('/core/') || file.includes('/modules/');
|
||||
const hasSrcInPath = file.includes('/src/core/') || file.includes('/src/modules/');
|
||||
|
||||
if (hasSrcInPath) {
|
||||
// bmadDir is parent of src (production: /path/to/BMAD-METHOD)
|
||||
if (module === 'core') {
|
||||
moduleBase = path.join(bmadDir, 'src', 'core');
|
||||
} else if (module === 'bmm') {
|
||||
moduleBase = path.join(bmadDir, 'src', 'bmm');
|
||||
moduleBase = path.join(bmadDir, 'src', 'modules', 'bmm');
|
||||
} else {
|
||||
moduleBase = path.join(bmadDir, 'src', 'modules', module);
|
||||
}
|
||||
} else {
|
||||
moduleBase = module === 'core' ? path.join(bmadDir, 'core') : path.join(bmadDir, 'modules', module);
|
||||
// bmadDir IS the src directory (test: tmpDir/src)
|
||||
if (module === 'core') {
|
||||
moduleBase = path.join(bmadDir, 'core');
|
||||
} else {
|
||||
moduleBase = path.join(bmadDir, 'modules', module);
|
||||
}
|
||||
}
|
||||
|
||||
const relative = path.relative(moduleBase, file);
|
||||
|
|
@ -642,9 +672,16 @@ class DependencyResolver {
|
|||
if (relative.startsWith('agents/') || file.includes('/agents/')) {
|
||||
organized[module].agents.push(file);
|
||||
} else if (relative.startsWith('tasks/') || file.includes('/tasks/')) {
|
||||
// Exclude brain-tech data files from tasks
|
||||
if (relative.includes('brain-tech/') && relative.endsWith('.csv')) {
|
||||
organized[module].data.push(file);
|
||||
} else {
|
||||
organized[module].tasks.push(file);
|
||||
}
|
||||
} else if (relative.startsWith('tools/') || file.includes('/tools/')) {
|
||||
organized[module].tools.push(file);
|
||||
} else if (relative.startsWith('templates/') || file.includes('/templates/')) {
|
||||
organized[module].templates.push(file);
|
||||
} else if (relative.includes('data/')) {
|
||||
organized[module].data.push(file);
|
||||
} else {
|
||||
|
|
|
|||
Loading…
Reference in New Issue