From 34cfdddd3aa19945e8ff342d6eec7e51dca8ca62 Mon Sep 17 00:00:00 2001
From: Brian Madison <brianmadison@Brians-MacBook-Pro.local>
Date: Mon, 22 Dec 2025 13:12:25 +0800
Subject: [PATCH] refac tools part 1

---
 tools/cli/installers/lib/core/installer.js  | 72 +++++++++------------
 tools/cli/installers/lib/ide/_base-ide.js   |  5 --
 tools/cli/installers/lib/modules/manager.js |  2 +-
 tools/cli/lib/agent-party-generator.js      |  2 +-
 tools/cli/lib/agent/xml-handler.js          |  7 --
 tools/cli/lib/agent/yaml-xml-builder.js     |  2 +-
 tools/{ => cli}/lib/xml-utils.js            |  0
 tools/flattener/xml.js                      |  2 +-
 8 files changed, 36 insertions(+), 56 deletions(-)
 rename tools/{ => cli}/lib/xml-utils.js (100%)

diff --git a/tools/cli/installers/lib/core/installer.js b/tools/cli/installers/lib/core/installer.js
index 8e6f5a4b..50f06d1c 100644
--- a/tools/cli/installers/lib/core/installer.js
+++ b/tools/cli/installers/lib/core/installer.js
@@ -297,49 +297,41 @@ class Installer {
         console.log('\n'); // Add spacing before IDE questions
 
         for (const ide of newlySelectedIdes) {
-          // List of IDEs that have interactive prompts
-          //TODO: Why is this here, hardcoding this list here is bad, fix me!
-          const needsPrompts = ['claude-code', 'github-copilot', 'roo', 'cline', 'auggie', 'codex', 'qwen', 'gemini', 'rovo-dev'].includes(
-            ide,
-          );
+          // Get IDE handler and check if it needs interactive configuration
+          try {
+            // Dynamically load the IDE setup module
+            const ideModule = require(`../ide/${ide}`);
 
-          if (needsPrompts) {
-            // Get IDE handler and collect configuration
-            try {
-              // Dynamically load the IDE setup module
-              const ideModule = require(`../ide/${ide}`);
+            // Get the setup class (handle different export formats)
+            let SetupClass;
+            const className =
+              ide
+                .split('-')
+                .map((part) => part.charAt(0).toUpperCase() + part.slice(1))
+                .join('') + 'Setup';
 
-              // Get the setup class (handle different export formats)
-              let SetupClass;
-              const className =
-                ide
-                  .split('-')
-                  .map((part) => part.charAt(0).toUpperCase() + part.slice(1))
-                  .join('') + 'Setup';
-
-              if (ideModule[className]) {
-                SetupClass = ideModule[className];
-              } else if (ideModule.default) {
-                SetupClass = ideModule.default;
-              } else {
-                continue;
-              }
-
-              const ideSetup = new SetupClass();
-
-              // Check if this IDE has a collectConfiguration method
-              if (typeof ideSetup.collectConfiguration === 'function') {
-                console.log(chalk.cyan(`\nConfiguring ${ide}...`));
-                ideConfigurations[ide] = await ideSetup.collectConfiguration({
-                  selectedModules: selectedModules || [],
-                  projectDir,
-                  bmadDir,
-                });
-              }
-            } catch {
-              // IDE doesn't have a setup file or collectConfiguration method
-              console.warn(chalk.yellow(`Warning: Could not load configuration for ${ide}`));
+            if (ideModule[className]) {
+              SetupClass = ideModule[className];
+            } else if (ideModule.default) {
+              SetupClass = ideModule.default;
+            } else {
+              continue;
             }
+
+            const ideSetup = new SetupClass();
+
+            // Check if this IDE has a collectConfiguration method (no hardcoding needed!)
+            if (typeof ideSetup.collectConfiguration === 'function') {
+              console.log(chalk.cyan(`\nConfiguring ${ide}...`));
+              ideConfigurations[ide] = await ideSetup.collectConfiguration({
+                selectedModules: selectedModules || [],
+                projectDir,
+                bmadDir,
+              });
+            }
+          } catch {
+            // IDE doesn't have a setup file or collectConfiguration method
+            console.warn(chalk.yellow(`Warning: Could not load configuration for ${ide}`));
           }
         }
       }
diff --git a/tools/cli/installers/lib/ide/_base-ide.js b/tools/cli/installers/lib/ide/_base-ide.js
index 1aedceb7..bfa9af88 100644
--- a/tools/cli/installers/lib/ide/_base-ide.js
+++ b/tools/cli/installers/lib/ide/_base-ide.js
@@ -493,11 +493,6 @@ class BaseIdeSetup {
     // Replace placeholders
     let processed = content;
 
-    // Inject activation block for agent files FIRST (before replacements)
-    if (metadata.name && content.includes('<agent')) {
-      processed = this.xmlHandler.injectActivationSimple(processed, metadata);
-    }
-
     // Only replace {project-root} if a specific projectDir is provided
     // Otherwise leave the placeholder intact
     // Note: Don't add trailing slash - paths in source include leading slash
diff --git a/tools/cli/installers/lib/modules/manager.js b/tools/cli/installers/lib/modules/manager.js
index c2acb34a..0cbf21c9 100644
--- a/tools/cli/installers/lib/modules/manager.js
+++ b/tools/cli/installers/lib/modules/manager.js
@@ -952,7 +952,7 @@ class ModuleManager {
     //   // Check if content has agent XML and no activation block
     //   if (content.includes('<agent') && !content.includes('<activation')) {
     //     // Inject the activation block using XML handler
-    //     content = this.xmlHandler.injectActivationSimple(content);
+    //     // TODO: Reimplement activation injection if needed
     //     await fs.writeFile(agentFile, content, 'utf8');
     //   }
     // }
diff --git a/tools/cli/lib/agent-party-generator.js b/tools/cli/lib/agent-party-generator.js
index efc783a8..92768774 100644
--- a/tools/cli/lib/agent-party-generator.js
+++ b/tools/cli/lib/agent-party-generator.js
@@ -1,6 +1,6 @@
 const path = require('node:path');
 const fs = require('fs-extra');
-const { escapeXml } = require('../../lib/xml-utils');
+const { escapeXml } = require('./xml-utils');
 
 const AgentPartyGenerator = {
   /**
diff --git a/tools/cli/lib/agent/xml-handler.js b/tools/cli/lib/agent/xml-handler.js
index a514e3a3..a12dbdf2 100644
--- a/tools/cli/lib/agent/xml-handler.js
+++ b/tools/cli/lib/agent/xml-handler.js
@@ -124,13 +124,6 @@ class XmlHandler {
     }
   }
 
-  /**
-   * TODO: DELETE THIS METHOD
-   */
-  injectActivationSimple(agentContent, metadata = {}) {
-    console.error('Error in simple injection:', error);
-  }
-
   /**
    * Build agent from YAML source
    * @param {string} yamlPath - Path to .agent.yaml file
diff --git a/tools/cli/lib/agent/yaml-xml-builder.js b/tools/cli/lib/agent/yaml-xml-builder.js
index 6ff97ea8..ae903a2f 100644
--- a/tools/cli/lib/agent/yaml-xml-builder.js
+++ b/tools/cli/lib/agent/yaml-xml-builder.js
@@ -4,7 +4,7 @@ const path = require('node:path');
 const crypto = require('node:crypto');
 const { AgentAnalyzer } = require('./agent-analyzer');
 const { ActivationBuilder } = require('./activation-builder');
-const { escapeXml } = require('../../../lib/xml-utils');
+const { escapeXml } = require('../xml-utils');
 const {
   processAgentYaml,
   extractInstallConfig,
diff --git a/tools/lib/xml-utils.js b/tools/cli/lib/xml-utils.js
similarity index 100%
rename from tools/lib/xml-utils.js
rename to tools/cli/lib/xml-utils.js
diff --git a/tools/flattener/xml.js b/tools/flattener/xml.js
index 229f9a88..60705b6b 100644
--- a/tools/flattener/xml.js
+++ b/tools/flattener/xml.js
@@ -1,5 +1,5 @@
 const fs = require('fs-extra');
-const { escapeXml } = require('../lib/xml-utils');
+const { escapeXml } = require('../cli/lib/xml-utils');
 
 function indentFileContent(content) {
   if (typeof content !== 'string') {