From 25dc48ae98b2103c497769d08c2e7bb0476362e1 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Tue, 23 Jun 2026 04:37:34 -0700 Subject: [PATCH] fix: strengthen dev auto verification gates Require the auto workflow to re-read its READY standard before judging the spec, and make implementation verification cover both tasks and acceptance criteria with a blocked HALT when missing work cannot be completed. --- src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md | 2 +- .../4-implementation/bmad-dev-auto/step-03-implement.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md index d89c69904..328b00f43 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/step-02-plan.md @@ -20,7 +20,7 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md' ### READY-FOR-DEVELOPMENT GATE -Re-read `{spec_file}` from disk and verify it meets the READY FOR DEVELOPMENT standard in `./SKILL.md`. +Re-read `./SKILL.md`, then re-read `{spec_file}` from disk and verify the spec meets the READY FOR DEVELOPMENT standard. - **If the file is missing:** HALT with status `blocked` and blocking condition `planned spec file disappeared before implementation`. - **If the spec meets the standard:** set `{spec_file}` frontmatter status to `ready-for-dev`, then continue to step 3. diff --git a/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md index 947985c76..710a9db77 100644 --- a/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-dev-auto/step-03-implement.md @@ -29,9 +29,9 @@ Hand `{spec_file}` to a sub-agent/task and let it implement. **Path formatting rule:** Any markdown links written into `{spec_file}` must use paths relative to `{spec_file}`'s directory so they are clickable in VS Code. Any file paths displayed in terminal/conversation output must use CWD-relative format with `:line` notation (e.g., `src/path/file.ts:42`) for terminal clickability. No leading `/` in either case. -### Active Session Verification +### Tasks & Acceptance Verification -After the implementation sub-agent returns, verify every task in the `## Tasks & Acceptance` section of `{spec_file}` is complete. Mark each finished task `[x]`. If any task is not done, finish it before proceeding. +After the implementation sub-agent returns, verify every task in the `## Tasks & Acceptance` section of `{spec_file}` is complete and every acceptance criterion is satisfied. Mark each finished task `[x]`. If any task is not done or any acceptance criterion is not satisfied, finish the missing work before proceeding. If the missing work cannot be completed, HALT with status `blocked` and include the unfinished task or failing acceptance criterion and reason. ## NEXT