From 072f249ad952eb2a600851993144efffe5493016 Mon Sep 17 00:00:00 2001 From: Michael Pursifull Date: Tue, 27 Jan 2026 23:53:09 -0600 Subject: [PATCH 1/3] fix: correct malformed XML syntax and remove hardcoded path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix missing opening quote in activation-steps.txt: `n={HELP_STEP}"` → `n="{HELP_STEP}"` - Remove spurious hyphen: `-Let` → `Let` - Replace hardcoded `/Users/brianmadison/...` path with relative path Fixes #1435 --- .../create-prd/validation-report-prd-workflow.md | 2 +- src/utility/agent-components/activation-steps.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md index 14407bfa..1939b65c 100644 --- a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md +++ b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md @@ -8,7 +8,7 @@ validationStatus: COMPLETE - PRODUCTION READY # PRD Workflow Validation Report -**Workflow Being Validated:** /Users/brianmadison/dev/BMAD-METHOD/src/bmm/workflows/2-plan-workflows/create-prd +**Workflow Being Validated:** src/bmm/workflows/2-plan-workflows/create-prd **Validation Date:** 2026-01-08 **Validator:** BMAD Workflow Validation System diff --git a/src/utility/agent-components/activation-steps.txt b/src/utility/agent-components/activation-steps.txt index 24def0af..9ead0e01 100644 --- a/src/utility/agent-components/activation-steps.txt +++ b/src/utility/agent-components/activation-steps.txt @@ -8,7 +8,7 @@ Remember: user's name is {user_name} {AGENT_SPECIFIC_STEPS} Show greeting using {user_name} from config, communicate in {communication_language}, then display numbered list of ALL menu items from menu section - -Let {user_name} know they can type command `/bmad-help` at any time to get advice on what to do next, and that they can combine that with what they need help with `/bmad-help where should I start with an idea I have that does XYZ` + Let {user_name} know they can type command `/bmad-help` at any time to get advice on what to do next, and that they can combine that with what they need help with `/bmad-help where should I start with an idea I have that does XYZ` STOP and WAIT for user input - do NOT execute menu items automatically - accept number or cmd trigger or fuzzy command match On user input: Number → process menu item[n] | Text → case-insensitive substring match | Multiple matches → ask user to clarify | No match → show "Not recognized" When processing a menu item: Check menu-handlers section below - extract any attributes from the selected menu item (workflow, exec, tmpl, data, action, validate-workflow) and follow the corresponding handler instructions \ No newline at end of file From fcf96c49457b99e15b1b0d12ebe66ed36a560a89 Mon Sep 17 00:00:00 2001 From: Michael Pursifull Date: Wed, 28 Jan 2026 00:35:20 -0600 Subject: [PATCH 2/3] fix: add missing HELP_STEP placeholder replacement The activation-steps.txt template includes a {HELP_STEP} placeholder, but activation-builder.js never calculated or replaced it. This caused the literal string "{HELP_STEP}" to appear in compiled agent files. Added helpStep calculation between menuStep and haltStep, and adjusted subsequent step numbers accordingly. Fixes #1441 --- tools/cli/lib/activation-builder.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/cli/lib/activation-builder.js b/tools/cli/lib/activation-builder.js index 9b91c2a9..81e11158 100644 --- a/tools/cli/lib/activation-builder.js +++ b/tools/cli/lib/activation-builder.js @@ -121,9 +121,10 @@ class ActivationBuilder { // Calculate final step numbers const menuStep = currentStepNum; - const haltStep = currentStepNum + 1; - const inputStep = currentStepNum + 2; - const executeStep = currentStepNum + 3; + const helpStep = currentStepNum + 1; + const haltStep = currentStepNum + 2; + const inputStep = currentStepNum + 3; + const executeStep = currentStepNum + 4; // Replace placeholders const processed = stepsTemplate @@ -131,6 +132,7 @@ class ActivationBuilder { .replace('{{module}}', metadata.module || 'core') // Fixed to use {{module}} .replace('{AGENT_SPECIFIC_STEPS}', agentStepsXml) .replace('{MENU_STEP}', menuStep.toString()) + .replace('{HELP_STEP}', helpStep.toString()) .replace('{HALT_STEP}', haltStep.toString()) .replace('{INPUT_STEP}', inputStep.toString()) .replace('{EXECUTE_STEP}', executeStep.toString()); From c4e13af51b7dfac4d1df4cacb4d8a4cd4aab07c7 Mon Sep 17 00:00:00 2001 From: Michael Pursifull Date: Wed, 28 Jan 2026 21:12:08 -0600 Subject: [PATCH 3/3] Update src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md --- .../create-prd/validation-report-prd-workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md index 1939b65c..0a49b9f2 100644 --- a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md +++ b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md @@ -8,7 +8,7 @@ validationStatus: COMPLETE - PRODUCTION READY # PRD Workflow Validation Report -**Workflow Being Validated:** src/bmm/workflows/2-plan-workflows/create-prd +**Workflow Being Validated:** _bmad/bmm/workflows/2-plan-workflows/create-prd **Validation Date:** 2026-01-08 **Validator:** BMAD Workflow Validation System