fix: update stale task terminology to skill after format conversion

Address review findings from PR #1857: replace remaining "task"
references with "skill" in workflow steps and test documentation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-03-08 06:46:46 -06:00
parent 5d5b994233
commit 1cbaeae643
4 changed files with 12 additions and 12 deletions

View File

@ -1,13 +1,13 @@
--- ---
name: 'step-05-adversarial-review' name: 'step-05-adversarial-review'
description: 'Construct diff and invoke adversarial review task' description: 'Construct diff and invoke adversarial review skill'
nextStepFile: './step-06-resolve-findings.md' nextStepFile: './step-06-resolve-findings.md'
--- ---
# Step 5: Adversarial Code Review # Step 5: Adversarial Code Review
**Goal:** Construct diff of all changes, invoke adversarial review task, present findings. **Goal:** Construct diff of all changes, invoke adversarial review skill, present findings.
--- ---
@ -65,7 +65,7 @@ Pass `{diff_output}` as the content to review. The skill should return a list of
### 3. Process Findings ### 3. Process Findings
Capture the findings from the task output. Capture the findings from the skill output.
**If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance. **If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance.
Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided). Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided).
DO NOT exclude findings based on severity or validity unless explicitly asked to do so. DO NOT exclude findings based on severity or validity unless explicitly asked to do so.
@ -85,7 +85,7 @@ With findings in hand, read fully and follow: `{project-root}/_bmad/bmm/workflow
- Diff constructed from baseline_commit - Diff constructed from baseline_commit
- New files included in diff - New files included in diff
- Task invoked with diff as input - Skill invoked with diff as input
- Findings received - Findings received
- Findings processed into TODOs or table and presented to user - Findings processed into TODOs or table and presented to user
@ -93,6 +93,6 @@ With findings in hand, read fully and follow: `{project-root}/_bmad/bmm/workflow
- Missing baseline_commit (can't construct accurate diff) - Missing baseline_commit (can't construct accurate diff)
- Not including new untracked files in diff - Not including new untracked files in diff
- Invoking task without providing diff input - Invoking skill without providing diff input
- Accepting zero findings without questioning - Accepting zero findings without questioning
- Presenting fewer findings than the review task returned without explicit instruction to do so - Presenting fewer findings than the review skill returned without explicit instruction to do so

View File

@ -156,7 +156,7 @@ b) **HALT and wait for user selection.**
> Pass `{finalFile}` as the content to review. The skill should return a list of findings. > Pass `{finalFile}` as the content to review. The skill should return a list of findings.
2. **Process Findings**: 2. **Process Findings**:
> Capture the findings from the task output. > Capture the findings from the skill output.
> **If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance. > **If zero findings:** HALT - this is suspicious. Re-analyze or request user guidance.
> Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided). > Evaluate severity (Critical, High, Medium, Low) and validity (real, noise, undecided).
> DO NOT exclude findings based on severity or validity unless explicitly asked to do so. > DO NOT exclude findings based on severity or validity unless explicitly asked to do so.

View File

@ -1,6 +1,6 @@
# Adversarial Review Test Suite # Adversarial Review Test Suite
Tests for the `also_consider` optional input in `review-adversarial-general.xml`. Tests for the `also_consider` optional input in the `bmad-review-adversarial-general` skill.
## Purpose ## Purpose
@ -19,12 +19,12 @@ All tests use `sample-content.md` - a deliberately imperfect User Authentication
## Running Tests ## Running Tests
For each test case in `test-cases.yaml`, invoke the adversarial review task. For each test case in `test-cases.yaml`, invoke the adversarial review skill.
### Manual Test Invocation ### Manual Test Invocation
``` ```
Review this content using the adversarial review task: Review this content using the adversarial review skill:
<content> <content>
[paste sample-content.md] [paste sample-content.md]

View File

@ -1,9 +1,9 @@
# Test Cases for review-adversarial-general.xml with also_consider input # Test Cases for bmad-review-adversarial-general skill with also_consider input
# #
# Purpose: Evaluate how the optional also_consider input influences review findings # Purpose: Evaluate how the optional also_consider input influences review findings
# Content: All tests use sample-content.md (User Authentication API docs) # Content: All tests use sample-content.md (User Authentication API docs)
# #
# To run: Manually invoke the task with each configuration and compare outputs # To run: Manually invoke the skill with each configuration and compare outputs
test_cases: test_cases:
# BASELINE - No also_consider # BASELINE - No also_consider