ldy26098
/
BMAD-METHOD
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git
1
0
Fork 0
Code Packages Projects Releases Wiki Activity

refactor(code-review): audit step-01 substeps and success/failure criteria 

Step 01 audit findings:
- Substep 3 was extracting items not needed by step-01 (ACs, tasks, changelog)
  Trimmed to only extract story_file_list (needed for git comparison)
- Success/failure criteria now explicitly guard story_content completeness
  since downstream steps depend on the full file content
- Removed "downstream" jargon in favor of "later steps"

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Alex Verkhovsky 2026-01-05 05:42:04 -08:00
parent 8fc7db7b97
commit 18ac3c931a
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/modules/bmm/workflows/4-implementation/code-review/steps/step-01-load-story.md
View File

@ -54,15 +54,9 @@ Read the complete contents of {story_path} and assign to `story_content` WITHOUT
**Extract story identifier:** **Extract story identifier:**
Verify the filename ends with `.md` extension. Remove `.md` to get `story_key` (e.g., "1-2-user-authentication.md" → "1-2-user-authentication"). If filename doesn't end with `.md` or the result is empty: report the error to the user and HALT the workflow. Verify the filename ends with `.md` extension. Remove `.md` to get `story_key` (e.g., "1-2-user-authentication.md" → "1-2-user-authentication"). If filename doesn't end with `.md` or the result is empty: report the error to the user and HALT the workflow.
### 3. Parse Story Sections ### 3. Extract File List from Story
Extract and store: Extract `story_file_list` from the Dev Agent Record → File List section of the story file.
- **Story**: Title, description, status
- **Acceptance Criteria**: All ACs with their requirements
- **Tasks/Subtasks**: All tasks with completion status ([x] vs [ ])
- **Dev Agent Record → File List**: Claimed file changes
- **Change Log**: History of modifications
Set `story_file_list` = list of files from Dev Agent Record → File List Set `story_file_list` = list of files from Dev Agent Record → File List
@ -110,7 +104,7 @@ Set `git_discrepancies` with categories:
- `story_path` identified and loaded - `story_path` identified and loaded
- `story_key` extracted - `story_key` extracted
- All story sections parsed - `story_content` captured completely and unmodified
- `story_file_list` compiled from Dev Agent Record - `story_file_list` compiled from Dev Agent Record
- `git_changed_files` discovered via git commands - `git_changed_files` discovered via git commands
- `git_discrepancies` calculated - `git_discrepancies` calculated
@ -121,7 +115,7 @@ Set `git_discrepancies` with categories:
- Proceeding without story file loaded - Proceeding without story file loaded
- Missing `story_key` extraction - Missing `story_key` extraction
- Not parsing all story sections - `story_content` incomplete or modified (breaks later steps)
- Skipping git change discovery - Skipping git change discovery
- Not calculating discrepancies - Not calculating discrepancies
- No explicit NEXT directive at step completion - No explicit NEXT directive at step completion