From 0bda1ba31dcf2d2c1bf04116fa0fd786916bd105 Mon Sep 17 00:00:00 2001 From: Murat Ozcan Date: Tue, 11 Nov 2025 10:49:58 -0600 Subject: [PATCH] chore: addressed PR comments --- .github/workflows/bundle-latest.yaml | 2 +- .github/workflows/manual-release.yaml | 3 --- docs/BUNDLE_DISTRIBUTION_SETUP.md | 22 ++++++++++++++-------- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/.github/workflows/bundle-latest.yaml b/.github/workflows/bundle-latest.yaml index eec094ec..1185f896 100644 --- a/.github/workflows/bundle-latest.yaml +++ b/.github/workflows/bundle-latest.yaml @@ -149,7 +149,7 @@ jobs: with: repository: bmad-code-org/bmad-bundles path: bmad-bundles - token: ${{ secrets.BUNDLES_DEPLOY_KEY }} + token: ${{ secrets.BUNDLES_PAT }} - name: Update bundles run: | diff --git a/.github/workflows/manual-release.yaml b/.github/workflows/manual-release.yaml index 03216714..8b1be007 100644 --- a/.github/workflows/manual-release.yaml +++ b/.github/workflows/manual-release.yaml @@ -61,9 +61,6 @@ jobs: run: | sed -i 's/"version": ".*"/"version": "${{ steps.version.outputs.new_version }}"/' tools/installer/package.json - - name: Build project - run: npm run build - - name: Generate web bundles run: npm run bundle diff --git a/docs/BUNDLE_DISTRIBUTION_SETUP.md b/docs/BUNDLE_DISTRIBUTION_SETUP.md index 4f7bc095..f206ee7f 100644 --- a/docs/BUNDLE_DISTRIBUTION_SETUP.md +++ b/docs/BUNDLE_DISTRIBUTION_SETUP.md @@ -26,11 +26,13 @@ gh api repos/bmad-code-org/bmad-bundles/pages --method POST -f source[branch]=ma # (Optional) confirm status gh api repos/bmad-code-org/bmad-bundles/pages --jq '{status,source}' -# 4. Create deploy key -ssh-keygen -t ed25519 -C "github-actions" -f deploy-key -N "" -gh repo deploy-key add deploy-key.pub --repo bmad-code-org/bmad-bundles --title "CI" --allow-write -gh secret set BUNDLES_DEPLOY_KEY --repo bmad-code-org/BMAD-METHOD < deploy-key -rm deploy-key* +# 4. Create GitHub PAT and add as secret +# Go to: https://github.com/settings/tokens/new +# Scopes: repo (full control) +# Name: bmad-bundles-ci +# Then add as secret: +gh secret set BUNDLES_PAT --repo bmad-code-org/BMAD-METHOD +# (paste PAT when prompted) ``` If the Pages POST returns `409`, the site already exists. If it returns `422` about `main` missing, redo step 2 to push the initial commit. @@ -43,7 +45,7 @@ If the Pages POST returns `409`, the site already exists. If it returns `422` ab **On main merge:** -- `.github/workflows/bundle-latest.yml` runs +- `.github/workflows/bundle-latest.yaml` runs - Publishes to: `https://bmad-code-org.github.io/bmad-bundles/` **On release:** @@ -69,10 +71,14 @@ npm run release:patch ## Troubleshooting -**"Permission denied (publickey)"** +**"Permission denied" or auth errors** ```bash -gh secret list --repo bmad-code-org/BMAD-METHOD | grep BUNDLES +# Verify PAT secret exists +gh secret list --repo bmad-code-org/BMAD-METHOD | grep BUNDLES_PAT + +# If missing, recreate PAT and add secret: +gh secret set BUNDLES_PAT --repo bmad-code-org/BMAD-METHOD ``` **GitHub Pages not updating / need to re-check config**