From 09316ecc7fb87680cafb764fa365384e4875a546 Mon Sep 17 00:00:00 2001 From: Brian Madison Date: Fri, 6 Feb 2026 21:16:14 -0600 Subject: [PATCH] fix: remove forbidden workflow_path variable from step files Remove the forbidden `workflow_path` frontmatter variable from 16 step files across 3 workflows (quick-dev, quick-spec, check-implementation-readiness). Per BMAD workflow standards, step files should use relative paths or {project-root} references instead. Changes: - quick-dev (6 files): removed workflow_path and unused thisStepFile - quick-spec (4 files): removed workflow_path, updated templateFile to use relative path - check-implementation-readiness (6 files): removed workflow_path, updated all references to use relative paths Also fixes incorrect path in check-implementation-readiness that referenced non-existent 'implementation-readiness' folder instead of 'check-implementation-readiness'. Fixes #1546 --- .../steps/step-01-document-discovery.md | 8 +------- .../steps/step-02-prd-analysis.md | 6 ------ .../steps/step-03-epic-coverage-validation.md | 6 ------ .../steps/step-04-ux-alignment.md | 6 ------ .../steps/step-05-epic-quality-review.md | 7 ------- .../steps/step-06-final-assessment.md | 6 ------ .../quick-dev/steps/step-01-mode-detection.md | 2 -- .../quick-dev/steps/step-02-context-gathering.md | 2 -- .../bmad-quick-flow/quick-dev/steps/step-03-execute.md | 2 -- .../bmad-quick-flow/quick-dev/steps/step-04-self-check.md | 2 -- .../quick-dev/steps/step-05-adversarial-review.md | 2 -- .../quick-dev/steps/step-06-resolve-findings.md | 3 --- .../quick-spec/steps/step-01-understand.md | 3 +-- .../quick-spec/steps/step-02-investigate.md | 1 - .../bmad-quick-flow/quick-spec/steps/step-03-generate.md | 1 - .../bmad-quick-flow/quick-spec/steps/step-04-review.md | 1 - 16 files changed, 2 insertions(+), 56 deletions(-) diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md index fccb7da22..877193f3d 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-01-document-discovery.md @@ -2,15 +2,9 @@ name: 'step-01-document-discovery' description: 'Discover and inventory all project documents, handling duplicates and organizing file structure' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-01-document-discovery.md' nextStepFile: './step-02-prd-analysis.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' -templateFile: '{workflow_path}/templates/readiness-report-template.md' +templateFile: '../templates/readiness-report-template.md' --- # Step 1: Document Discovery diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md index 5dd08705a..4d22e7da9 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-02-prd-analysis.md @@ -2,13 +2,7 @@ name: 'step-02-prd-analysis' description: 'Read and analyze PRD to extract all FRs and NFRs for coverage validation' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-02-prd-analysis.md' nextStepFile: './step-03-epic-coverage-validation.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' epicsFile: '{planning_artifacts}/*epic*.md' # Will be resolved to actual file --- diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md index 981a5b63a..b73511bea 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-03-epic-coverage-validation.md @@ -2,13 +2,7 @@ name: 'step-03-epic-coverage-validation' description: 'Validate that all PRD FRs are covered in epics and stories' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-03-epic-coverage-validation.md' nextStepFile: './step-04-ux-alignment.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' --- diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md index 33aad045d..236ad3b51 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-04-ux-alignment.md @@ -2,13 +2,7 @@ name: 'step-04-ux-alignment' description: 'Check for UX document and validate alignment with PRD and Architecture' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-04-ux-alignment.md' nextStepFile: './step-05-epic-quality-review.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' --- diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md index 0203cdc1a..9f6d087f8 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-05-epic-quality-review.md @@ -2,15 +2,8 @@ name: 'step-05-epic-quality-review' description: 'Validate epics and stories against create-epics-and-stories best practices' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-05-epic-quality-review.md' nextStepFile: './step-06-final-assessment.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' -epicsBestPractices: '{project-root}/_bmad/bmm/workflows/3-solutioning/create-epics-and-stories' --- # Step 5: Epic Quality Review diff --git a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md index cc826ee95..f78161e7f 100644 --- a/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md +++ b/src/bmm/workflows/3-solutioning/check-implementation-readiness/steps/step-06-final-assessment.md @@ -2,12 +2,6 @@ name: 'step-06-final-assessment' description: 'Compile final assessment and polish the readiness report' -# Path Definitions -workflow_path: '{project-root}/_bmad/bmm/workflows/3-solutioning/implementation-readiness' - -# File References -thisStepFile: './step-06-final-assessment.md' -workflowFile: '{workflow_path}/workflow.md' outputFile: '{planning_artifacts}/implementation-readiness-report-{{date}}.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-01-mode-detection.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-01-mode-detection.md index 4ea630b19..eb3458891 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-01-mode-detection.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-01-mode-detection.md @@ -2,8 +2,6 @@ name: 'step-01-mode-detection' description: 'Determine execution mode (tech-spec vs direct), handle escalation, set state variables' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-01-mode-detection.md' nextStepFile_modeA: './step-03-execute.md' nextStepFile_modeB: './step-02-context-gathering.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-02-context-gathering.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-02-context-gathering.md index dffb86a8c..d3461bb16 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-02-context-gathering.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-02-context-gathering.md @@ -2,8 +2,6 @@ name: 'step-02-context-gathering' description: 'Quick context gathering for direct mode - identify files, patterns, dependencies' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-02-context-gathering.md' nextStepFile: './step-03-execute.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-03-execute.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-03-execute.md index 9d7283614..baeab834b 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-03-execute.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-03-execute.md @@ -2,8 +2,6 @@ name: 'step-03-execute' description: 'Execute implementation - iterate through tasks, write code, run tests' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-03-execute.md' nextStepFile: './step-04-self-check.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-04-self-check.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-04-self-check.md index 6179ebba4..0c6a822c3 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-04-self-check.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-04-self-check.md @@ -2,8 +2,6 @@ name: 'step-04-self-check' description: 'Self-audit implementation against tasks, tests, AC, and patterns' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-04-self-check.md' nextStepFile: './step-05-adversarial-review.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md index 659553215..41c8f4741 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-05-adversarial-review.md @@ -2,8 +2,6 @@ name: 'step-05-adversarial-review' description: 'Construct diff and invoke adversarial review task' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-05-adversarial-review.md' nextStepFile: './step-06-resolve-findings.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md index 4ab367c62..5c9165c86 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-dev/steps/step-06-resolve-findings.md @@ -1,9 +1,6 @@ --- name: 'step-06-resolve-findings' description: 'Handle review findings interactively, apply fixes, update tech-spec with final status' - -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-dev' -thisStepFile: './step-06-resolve-findings.md' --- # Step 6: Resolve Findings diff --git a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-01-understand.md b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-01-understand.md index a7cde5558..d338f24b7 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-01-understand.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-01-understand.md @@ -2,10 +2,9 @@ name: 'step-01-understand' description: 'Analyze the requirement delta between current state and what user wants to build' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec' nextStepFile: './step-02-investigate.md' skipToStepFile: './step-03-generate.md' -templateFile: '{workflow_path}/tech-spec-template.md' +templateFile: '../tech-spec-template.md' wipFile: '{implementation_artifacts}/tech-spec-wip.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-02-investigate.md b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-02-investigate.md index 1b0d0ceeb..533c0d55b 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-02-investigate.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-02-investigate.md @@ -2,7 +2,6 @@ name: 'step-02-investigate' description: 'Map technical constraints and anchor points within the codebase' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec' nextStepFile: './step-03-generate.md' wipFile: '{implementation_artifacts}/tech-spec-wip.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-03-generate.md b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-03-generate.md index 79999db39..1a163ccb0 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-03-generate.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-03-generate.md @@ -2,7 +2,6 @@ name: 'step-03-generate' description: 'Build the implementation plan based on the technical mapping of constraints' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec' nextStepFile: './step-04-review.md' wipFile: '{implementation_artifacts}/tech-spec-wip.md' --- diff --git a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md index 29e5a59d6..24c65d088 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md @@ -2,7 +2,6 @@ name: 'step-04-review' description: 'Review and finalize the tech-spec' -workflow_path: '{project-root}/_bmad/bmm/workflows/bmad-quick-flow/quick-spec' wipFile: '{implementation_artifacts}/tech-spec-wip.md' ---