From 08a9d1d3e33a4eb326b1041bb45decff6b4cb83e Mon Sep 17 00:00:00 2001
From: Dicky Moore <dickymoore@gmail.com>
Date: Sun, 8 Mar 2026 17:48:01 +0000
Subject: [PATCH] chore(lean): drop skill-manifest refactors from PoC scope

---
 .../lib/ide/shared/skill-manifest.js          | 26 +++++--------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/tools/cli/installers/lib/ide/shared/skill-manifest.js b/tools/cli/installers/lib/ide/shared/skill-manifest.js
index f80235ab0..22a7cceef 100644
--- a/tools/cli/installers/lib/ide/shared/skill-manifest.js
+++ b/tools/cli/installers/lib/ide/shared/skill-manifest.js
@@ -3,7 +3,7 @@ const fs = require('fs-extra');
 const yaml = require('yaml');
 
 /**
- * Load skill manifest from a directory.
+ * Load bmad-skill-manifest.yaml from a directory.
  * Single-entry manifests (canonicalId at top level) apply to all files in the directory.
  * Multi-entry manifests are keyed by source filename.
  * @param {string} dirPath - Directory to check for bmad-skill-manifest.yaml
@@ -31,30 +31,18 @@ async function loadSkillManifest(dirPath) {
  * @returns {string} canonicalId or empty string
  */
 function getCanonicalId(manifest, filename) {
-  const manifestEntry = resolveManifestEntry(manifest, filename);
-  return manifestEntry?.canonicalId || '';
-}
-
-/**
- * Resolve a manifest entry for a source filename.
- * Handles single-entry manifests and extension fallbacks.
- * @param {Object|null} manifest - Loaded manifest
- * @param {string} filename - Source filename
- * @returns {Object|null} Manifest entry object
- */
-function resolveManifestEntry(manifest, filename) {
-  if (!manifest) return null;
+  if (!manifest) return '';
   // Single-entry manifest applies to all files in the directory
-  if (manifest.__single) return manifest.__single;
+  if (manifest.__single) return manifest.__single.canonicalId || '';
   // Multi-entry: look up by filename directly
-  if (manifest[filename]) return manifest[filename];
+  if (manifest[filename]) return manifest[filename].canonicalId || '';
   // Fallback: try alternate extensions for compiled files
   const baseName = filename.replace(/\.(md|xml)$/i, '');
   const agentKey = `${baseName}.agent.yaml`;
-  if (manifest[agentKey]) return manifest[agentKey];
+  if (manifest[agentKey]) return manifest[agentKey].canonicalId || '';
   const xmlKey = `${baseName}.xml`;
-  if (manifest[xmlKey]) return manifest[xmlKey];
-  return null;
+  if (manifest[xmlKey]) return manifest[xmlKey].canonicalId || '';
+  return '';
 }
 
 /**