From 17e87f8164d24dac4e609917930a4965ebb4608f Mon Sep 17 00:00:00 2001 From: 2-gabadi Date: Wed, 25 Mar 2026 03:25:39 -0300 Subject: [PATCH 1/4] fix: add consumer propagation check to bmad-quick-dev workflow When introducing new type variants, error codes, or DB values, the workflow now requires enumerating all consumers in the Code Map during planning (step-02) and HALTs implementation (step-03) if consumer tracing was missed. Fixes #2122 Co-Authored-By: Claude Sonnet 4.6 --- src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md | 2 +- .../4-implementation/bmad-quick-dev/step-03-implement.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md index 361d4c566..03e1dd3ce 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md @@ -12,7 +12,7 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md' ## INSTRUCTIONS -1. Investigate codebase. _Isolate deep exploration in sub-agents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._ +1. Investigate codebase. _Isolate deep exploration in sub-agents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._ If the approach introduces new type variants, error codes, or DB values: grep all consumers of the parent type/column and annotate each in the Code Map as `consumer — update required` or `consumer — excluded (reason)`. 2. Read `./spec-template.md` fully. Fill it out based on the intent and investigation, and write the result to `{wipFile}`. 3. Self-review against READY FOR DEVELOPMENT standard. 4. If intent gaps exist, do not fantasize, do not leave open questions, HALT and ask the human. diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md index 2d827b1f3..3a7df4bd7 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md @@ -14,6 +14,8 @@ Verify `{spec_file}` resolves to a non-empty path and the file exists on disk. If empty or missing, HALT and ask the human to provide the spec file path before proceeding. +If the spec introduces new type variants, error codes, or DB values and the Code Map has no consumer annotations, HALT — consumer tracing was missed in planning. + ## INSTRUCTIONS ### Baseline From cb60c06a2978ccb7a0d2ecb5e554762d4a2efbb9 Mon Sep 17 00:00:00 2001 From: 2-gabadi Date: Wed, 25 Mar 2026 03:30:19 -0300 Subject: [PATCH 2/4] fix: reference exact annotation prefix in step-03 HALT gate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use backtick-quoted `consumer —` prefix to match the step-02 convention, making the precondition check unambiguous and grepable. Co-Authored-By: Claude Sonnet 4.6 --- .../4-implementation/bmad-quick-dev/step-03-implement.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md index 3a7df4bd7..4485824be 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md @@ -14,7 +14,7 @@ Verify `{spec_file}` resolves to a non-empty path and the file exists on disk. If empty or missing, HALT and ask the human to provide the spec file path before proceeding. -If the spec introduces new type variants, error codes, or DB values and the Code Map has no consumer annotations, HALT — consumer tracing was missed in planning. +If the spec introduces new type variants, error codes, or DB values and the Code Map has no `consumer —` annotations, HALT — consumer tracing was missed in planning. ## INSTRUCTIONS From df8b54c9462b5ad6eccb65a0f2c905a362b1ca63 Mon Sep 17 00:00:00 2001 From: 2-gabadi Date: Wed, 25 Mar 2026 03:37:45 -0300 Subject: [PATCH 3/4] fix: handle zero-consumers case and add recovery path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - step-02: add `consumer — none found` annotation for empty grep results - step-03: replace dead-end HALT with actionable recovery (perform tracing now) so the agent isn't stuck if step-02 was skipped Co-Authored-By: Claude Sonnet 4.6 --- src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md | 2 +- .../4-implementation/bmad-quick-dev/step-03-implement.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md index 03e1dd3ce..63fadf89e 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-02-plan.md @@ -12,7 +12,7 @@ deferred_work_file: '{implementation_artifacts}/deferred-work.md' ## INSTRUCTIONS -1. Investigate codebase. _Isolate deep exploration in sub-agents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._ If the approach introduces new type variants, error codes, or DB values: grep all consumers of the parent type/column and annotate each in the Code Map as `consumer — update required` or `consumer — excluded (reason)`. +1. Investigate codebase. _Isolate deep exploration in sub-agents/tasks where available. To prevent context snowballing, instruct subagents to give you distilled summaries only._ If the approach introduces new type variants, error codes, or DB values: grep all consumers of the parent type/column and annotate each in the Code Map as `consumer — update required` or `consumer — excluded (reason)`. If no consumers exist, note `consumer — none found`. 2. Read `./spec-template.md` fully. Fill it out based on the intent and investigation, and write the result to `{wipFile}`. 3. Self-review against READY FOR DEVELOPMENT standard. 4. If intent gaps exist, do not fantasize, do not leave open questions, HALT and ask the human. diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md index 4485824be..9130c18da 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md @@ -14,7 +14,7 @@ Verify `{spec_file}` resolves to a non-empty path and the file exists on disk. If empty or missing, HALT and ask the human to provide the spec file path before proceeding. -If the spec introduces new type variants, error codes, or DB values and the Code Map has no `consumer —` annotations, HALT — consumer tracing was missed in planning. +If the spec introduces new type variants, error codes, or DB values and the Code Map has no `consumer —` annotations, perform consumer tracing now before proceeding. ## INSTRUCTIONS From 92b7c12bf24acbadc423b030d727b8b42673f2ac Mon Sep 17 00:00:00 2001 From: 2-gabadi Date: Wed, 25 Mar 2026 03:41:06 -0300 Subject: [PATCH 4/4] fix: remove redundant step-03 precondition The step-03 consumer tracing instruction duplicated step-02 without adding validation. Keep only the step-02 planning instruction. Co-Authored-By: Claude Sonnet 4.6 --- .../4-implementation/bmad-quick-dev/step-03-implement.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md index 9130c18da..2d827b1f3 100644 --- a/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md +++ b/src/bmm-skills/4-implementation/bmad-quick-dev/step-03-implement.md @@ -14,8 +14,6 @@ Verify `{spec_file}` resolves to a non-empty path and the file exists on disk. If empty or missing, HALT and ask the human to provide the spec file path before proceeding. -If the spec introduces new type variants, error codes, or DB values and the Code Map has no `consumer —` annotations, perform consumer tracing now before proceeding. - ## INSTRUCTIONS ### Baseline