From cf12697dfb31543a90648fa62df40bf17097df84 Mon Sep 17 00:00:00 2001 From: Alex Verkhovsky Date: Thu, 29 Jan 2026 01:11:48 -0700 Subject: [PATCH] fix: replace quote delimiters with output-block tags in step-04-review Double-quote delimiters around multi-line output template blocks are visually ambiguous to humans (opening quote on one line, closing quote many lines later) and confuse linters and LLM code reviewers into filing false issues (see #1434). A/B tested across 5 models (Opus, Sonnet, Haiku, Codex 5.2, Gemini): removing quotes entirely causes Haiku to refuse instructions in 1/3 runs, but any explicit block delimiter works equally well. XML-style output-block tags are the best fit: visually obvious boundaries, self-documenting, linter-clean, and consistent with existing BMAD XML tag conventions (step, action, check, template-output). Relates to #1433 --- .../quick-spec/steps/step-04-review.md | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md index a223a2e4..8c4f0926 100644 --- a/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md +++ b/src/bmm/workflows/bmad-quick-flow/quick-spec/steps/step-04-review.md @@ -31,19 +31,25 @@ wipFile: '{implementation_artifacts}/tech-spec-wip.md' **Present to user:** -"Here's your complete tech-spec. Please review:" + +Here's your complete tech-spec. Please review: + [Display the complete spec content - all sections] -"**Quick Summary:** + +**Quick Summary:** - {task_count} tasks to implement - {ac_count} acceptance criteria to verify -- {files_count} files to modify" +- {files_count} files to modify + **Present review menu:** -Display: "**Select:** [C] Continue [E] Edit [Q] Questions [A] Advanced Elicitation [P] Party Mode" + +**Select:** [C] Continue [E] Edit [Q] Questions [A] Advanced Elicitation [P] Party Mode + **HALT and wait for user selection.** @@ -173,7 +179,8 @@ b) **HALT and wait for user selection.** **When user selects [D]:** -"**All done!** Your tech-spec is ready at: + +**All done!** Your tech-spec is ready at: `{finalFile}` @@ -183,7 +190,8 @@ When you're ready to implement, run: quick-dev {finalFile} ``` -Ship it!" +Ship it! + ---