From 0992267f497dc8cf31392cb6c22fd20e2122f287 Mon Sep 17 00:00:00 2001 From: Serhii Date: Fri, 19 Dec 2025 09:09:02 +0200 Subject: [PATCH] fix(bmm): resolve dead references and syntax errors in agents and workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix XML syntax error in dev-story/instructions.xml:20 (goto element) - Fix path typo in tech-writer.agent.yaml (_bmadbmm → _bmad/bmm) - Fix wrong route in analyst.agent.yaml (edit-agent → party-mode) - Comment out unimplemented validate-create-story in sm.agent.yaml - Comment out unimplemented validate-design in ux-designer.agent.yaml - Remove misleading validate-create-story reference in create-story output Fixes #1075 Related to #1163 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- src/modules/bmm/agents/analyst.agent.yaml | 2 +- src/modules/bmm/agents/sm.agent.yaml | 9 ++++++--- src/modules/bmm/agents/tech-writer.agent.yaml | 2 +- src/modules/bmm/agents/ux-designer.agent.yaml | 9 ++++++--- .../4-implementation/create-story/instructions.xml | 14 ++------------ .../4-implementation/dev-story/instructions.xml | 2 +- 6 files changed, 17 insertions(+), 21 deletions(-) diff --git a/src/modules/bmm/agents/analyst.agent.yaml b/src/modules/bmm/agents/analyst.agent.yaml index dbe46d1c..9a1add04 100644 --- a/src/modules/bmm/agents/analyst.agent.yaml +++ b/src/modules/bmm/agents/analyst.agent.yaml @@ -43,7 +43,7 @@ agent: triggers: - party-mode: - input: SPM or fuzzy match start party mode - - route: "{project-root}/_bmad/core/workflows/edit-agent/workflow.md" + - route: "{project-root}/_bmad/core/workflows/party-mode/workflow.md" - data: what is being discussed or suggested with the command, along with custom party custom agents if specified - type: exec - expert-chat: diff --git a/src/modules/bmm/agents/sm.agent.yaml b/src/modules/bmm/agents/sm.agent.yaml index 26e2fe06..64262df4 100644 --- a/src/modules/bmm/agents/sm.agent.yaml +++ b/src/modules/bmm/agents/sm.agent.yaml @@ -32,9 +32,12 @@ agent: workflow: "{project-root}/_bmad/bmm/workflows/4-implementation/create-story/workflow.yaml" description: Create Story (Required to prepare stories for development) - - trigger: validate-create-story - validate-workflow: "{project-root}/_bmad/bmm/workflows/4-implementation/create-story/workflow.yaml" - description: Validate Story (Highly Recommended, use fresh context and different LLM for best results) + # TODO: validate-create-story is not yet implemented + # The validate-workflow: handler type is not recognized by the workflow engine + # See: https://github.com/bmad-code-org/BMAD-METHOD/issues/1075 + # - trigger: validate-create-story + # workflow: "{project-root}/_bmad/bmm/workflows/4-implementation/create-story/validate-workflow.yaml" + # description: Validate Story (Highly Recommended, use fresh context and different LLM for best results) - trigger: epic-retrospective workflow: "{project-root}/_bmad/bmm/workflows/4-implementation/retrospective/workflow.yaml" diff --git a/src/modules/bmm/agents/tech-writer.agent.yaml b/src/modules/bmm/agents/tech-writer.agent.yaml index a5eb9252..48b68e83 100644 --- a/src/modules/bmm/agents/tech-writer.agent.yaml +++ b/src/modules/bmm/agents/tech-writer.agent.yaml @@ -54,7 +54,7 @@ agent: description: Create clear technical explanations with examples - trigger: standards-guide - action: "Display the complete documentation standards from {project-root}/_bmadbmm/data/documentation-standards.md in a clear, formatted way for the user." + action: "Display the complete documentation standards from {project-root}/_bmad/bmm/data/documentation-standards.md in a clear, formatted way for the user." description: Show BMAD documentation standards reference (CommonMark, Mermaid, OpenAPI) - trigger: party-mode diff --git a/src/modules/bmm/agents/ux-designer.agent.yaml b/src/modules/bmm/agents/ux-designer.agent.yaml index b269fd01..2bf7a844 100644 --- a/src/modules/bmm/agents/ux-designer.agent.yaml +++ b/src/modules/bmm/agents/ux-designer.agent.yaml @@ -27,9 +27,12 @@ agent: exec: "{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-ux-design/workflow.md" description: Generate a UX Design and UI Plan from a PRD (Recommended before creating Architecture) - - trigger: validate-design - validate-workflow: "{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-ux-design/workflow.yaml" - description: Validate UX Specification and Design Artifacts + # TODO: validate-design is not yet implemented + # The validate-workflow: handler type is not recognized by the workflow engine + # See: https://github.com/bmad-code-org/BMAD-METHOD/issues/1075 + # - trigger: validate-design + # workflow: "{project-root}/_bmad/bmm/workflows/2-plan-workflows/create-ux-design/validate-workflow.yaml" + # description: Validate UX Specification and Design Artifacts - trigger: create-excalidraw-wireframe workflow: "{project-root}/_bmad/bmm/workflows/excalidraw-diagrams/create-wireframe/workflow.yaml" diff --git a/src/modules/bmm/workflows/4-implementation/create-story/instructions.xml b/src/modules/bmm/workflows/4-implementation/create-story/instructions.xml index e3805451..52405e71 100644 --- a/src/modules/bmm/workflows/4-implementation/create-story/instructions.xml +++ b/src/modules/bmm/workflows/4-implementation/create-story/instructions.xml @@ -334,18 +334,8 @@ **Next Steps:** 1. Review the comprehensive story in {{story_file}} - 2. **Optional Quality Competition:** Run the scrum masters `*validate-create-story` to have a fresh LLM systematically review and - improve the story context - 3. Run dev agents `dev-story` for optimized implementation - 4. Run `code-review` when complete (auto-marks done) - - **Quality Competition Option:** The `*validate-create-story` command runs the story context through an independent LLM in fresh - context that will: - - Systematically re-analyze all source documents - - Identify any misses, omissions, or improvements - - Compete to create a more comprehensive story context - - Present findings interactively for your approval - - Apply improvements to create the ultimate developer implementation guide + 2. Run dev agents `dev-story` for optimized implementation + 3. Run `code-review` when complete (auto-marks done) **The developer now has everything needed for flawless implementation!** diff --git a/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml b/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml index 47e76f07..40c56244 100644 --- a/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml +++ b/src/modules/bmm/workflows/4-implementation/dev-story/instructions.xml @@ -17,7 +17,7 @@ Use {{story_path}} directly Read COMPLETE story file Extract story_key from filename or metadata - anchor with id task_check +